Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6 backport] Asn1 missing guard in rsa backport #9042

Merged
merged 3 commits into from
Apr 22, 2024
Merged

[3.6 backport] Asn1 missing guard in rsa backport #9042

merged 3 commits into from
Apr 22, 2024

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Apr 19, 2024 •
edited by mpg
Loading

Description

Backport of #9035

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

@valeriosetti
adjust_legacy_crypto: enable ASN1_[PARSE|WRITE]_C when RSA_C
11530fd 
RSA needs ASN1 functions to parse/write private and public keys,
but there is no guards in the code for that. So we need to enable
ASN1 support whenever RSA is enabled.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
add changelog
82c3b40 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti valeriosetti added bug needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Apr 19, 2024
@valeriosetti valeriosetti self-assigned this Apr 19, 2024
@valeriosetti valeriosetti changed the base branch from development to mbedtls-3.6 April 19, 2024 07:41
@valeriosetti valeriosetti mentioned this pull request Apr 19, 2024
Merged
4 tasks
@valeriosetti
changelog: fix text
0595dc6 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
gilles-peskine-arm
gilles-peskine-arm approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - faithful backport

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 19, 2024
@mpg mpg added this pull request to the merge queue Apr 22, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit b9f9c0e Apr 22, 2024
6 checks passed
@valeriosetti valeriosetti deleted the asn1-missing-guard-in-rsa-backport branch December 6, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@mpg mpg Awaiting requested review from mpg

Assignees

@valeriosetti valeriosetti

Labels
approved Design and code approved - may be waiting for CI or backports bug priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
No open projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valeriosetti @gilles-peskine-arm @tom-cosgrove-arm @mpg