Auto-enable ASN1 when RSA is enabled #9035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriosetti
added
bug
needs-review
|
@mpg I added you as reviewer because this issue is related to the work we did recently on RSA. If you don't have time to review this please let me know and I will remove you form the reviewers list ;) |
RSA needs ASN1 functions to parse/write private and public keys, but there is no guards in the code for that. So we need to enable ASN1 support whenever RSA is enabled. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
valeriosetti
force-pushed
the
asn1-missing-guard-in-rsa
branch
from
fc91ef4 to
89f5af8
Compare
| @@ -293,6 +293,14 @@ | |||
| #define MBEDTLS_ECP_LIGHT | |||
| #endif | |||
|
|
|||
There was a problem hiding this comment.
Please add a changelog entry. It would even be nice to file an issue, to be more visible to other people who might encounter the problem.
There was a problem hiding this comment.
I just created the issue: #9041
gilles-peskine-arm
removed
the
needs-reviewer
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
4 tasks
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RSA needs ASN1 functions to parse/write private and public keys, but there is no guards in the code for that. So we need to enable ASN1 support whenever RSA is enabled.
Resolves #9041.
PR checklist