-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 3.6] Adapt test_keys.h and test_cert.h generation #10069
Merged
ronald-cron-arm
merged 2 commits into
Mbed-TLS:mbedtls-3.6
from
ronald-cron-arm:check-generated-files-3.6
Mar 27, 2025
Merged
[Backport 3.6] Adapt test_keys.h and test_cert.h generation #10069
ronald-cron-arm
merged 2 commits into
Mbed-TLS:mbedtls-3.6
from
ronald-cron-arm:check-generated-files-3.6
Mar 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
Merged
valeriosetti
previously approved these changes
Mar 18, 2025
gabor-mezei-arm
previously approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ronald-cron-arm
added a commit
to Mbed-TLS/mbedtls-framework
that referenced
this pull request
Mar 25, 2025
Enable checking of generated files and code style in TF-PSA-Crypto Validated by the CI of Mbed-TLS/mbedtls#10062 and Mbed-TLS/mbedtls#10069.
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
f810d44
b38c7e6
to
f810d44
Compare
I've rebased on top of mbedtls-3.6 head and updated the commit "Update framework pointer" with the merge of f#149. |
valeriosetti
approved these changes
Mar 26, 2025
gabor-mezei-arm
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Design and code approved - may be waiting for CI or backports
enhancement
priority-high
High priority - will be reviewed soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt test_keys.h and test_cert.h generation to the changes done in Mbed-TLS/mbedtls-framework#149 for the sake of Mbed-TLS/TF-PSA-Crypto#201.
Fixes the component check_generated_files failing in the CI of Mbed-TLS/mbedtls-framework#149 against 3.6.
PR checklist