Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 3.6] Adapt test_keys.h and test_cert.h generation #10069

Merged

Conversation

ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Mar 17, 2025

Description

Adapt test_keys.h and test_cert.h generation to the changes done in Mbed-TLS/mbedtls-framework#149 for the sake of Mbed-TLS/TF-PSA-Crypto#201.
Fixes the component check_generated_files failing in the CI of Mbed-TLS/mbedtls-framework#149 against 3.6.

PR checklist

valeriosetti
valeriosetti previously approved these changes Mar 18, 2025
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabor-mezei-arm gabor-mezei-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Mar 21, 2025
ronald-cron-arm added a commit to Mbed-TLS/mbedtls-framework that referenced this pull request Mar 25, 2025
Enable checking of generated files and code style in TF-PSA-Crypto
Validated by the CI of Mbed-TLS/mbedtls#10062 and Mbed-TLS/mbedtls#10069.
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Copy link
Contributor Author

I've rebased on top of mbedtls-3.6 head and updated the commit "Update framework pointer" with the merge of f#149.

@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Mar 25, 2025
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabor-mezei-arm gabor-mezei-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Mar 26, 2025
@ronald-cron-arm ronald-cron-arm merged commit a1dd7fa into Mbed-TLS:mbedtls-3.6 Mar 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-high High priority - will be reviewed soon
Development

Successfully merging this pull request may close these issues.

4 participants