Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check generated files and check code style test components #201

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Add check generated files and check code style test components #201

wants to merge 6 commits into from

Conversation

ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Mar 13, 2025 •
edited
Loading

Description

Fixes #48, #50.

PR checklist

@ronald-cron-arm ronald-cron-arm mentioned this pull request Mar 13, 2025
Open
6 tasks
@ronald-cron-arm ronald-cron-arm added enhancement New feature or request priority-high High priority - will be reviewed soon labels Mar 13, 2025
@ronald-cron-arm ronald-cron-arm mentioned this pull request Mar 13, 2025
Merged
3 tasks
@ronald-cron-arm ronald-cron-arm changed the title Add check generated files and ceck code style test components Add check generated files and check code style test components Mar 13, 2025
@ronald-cron-arm ronald-cron-arm force-pushed the check-generated-files branch 3 times, most recently from 56f7274 to 4087700 Compare March 15, 2025 09:30
@ronald-cron-arm ronald-cron-arm mentioned this pull request Mar 17, 2025
Open
6 tasks
@ronald-cron-arm ronald-cron-arm added needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Mar 17, 2025
@valeriosetti valeriosetti self-requested a review March 17, 2025 09:40
valeriosetti
valeriosetti previously approved these changes Mar 17, 2025
View reviewed changes
This was referenced Mar 18, 2025
Closed
Closed
gabor-mezei-arm
gabor-mezei-arm previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabor-mezei-arm gabor-mezei-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Mar 20, 2025
valeriosetti
valeriosetti previously approved these changes Mar 25, 2025
View reviewed changes
@ronald-cron-arm
Remove unnecessary test suite config data file filtering
f301057 
In TF-PSA-Crypto, generate_config_tests.py generates
only test_suite_config.psa_boolean.data. No need to
filter some Mbed TLS one.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Update framework pointer
4ef210a 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Generate test_keys.h in the build tree
8d5992a 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
all.sh: Add check_generated_files component
790fc06 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
all.sh: Add check_code_style component
46793e3 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Update framework pointer
ccfebeb 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
gabor-mezei-arm
gabor-mezei-arm previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm
Copy link
Contributor Author

I had to rebase on top of development HEAD as new merged PRs introduced code style issues that the new component tf_psa_crypto_check_code_style added in this PR complains about. I updated the commit
"all.sh: Add check_code_style component" with the code style checks.

gabor-mezei-arm
gabor-mezei-arm approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@valeriosetti valeriosetti valeriosetti left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports enhancement New feature or request priority-high High priority - will be reviewed soon
Projects
Mbed TLS Epics
Status: TF-PSA-Crypto all.sh 1 - basic-checks
Roadmap pull requests (new board)
Status: Has Approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code style check
3 participants
@ronald-cron-arm @gabor-mezei-arm @valeriosetti