Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lld): 🔒 ASAR integrity check #8748

Merged
merged 13 commits into from
Jan 21, 2025
Merged

feat(lld): 🔒 ASAR integrity check #8748

merged 13 commits into from
Jan 21, 2025

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 20, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR enables the ASAR integrity check and upgrade electron builder to v25 to enable it on Windows too.
It also addresses the build issues that arise due to the electron builder update.

More details in the tech research

🎥 Demo:

On MacOS:

MacASARCheck.mov

On Windows:

WinASARCheck.mp4

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:04am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:04am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:04am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:04am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Jan 5, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch 4 times, most recently from f9aa1a6 to 61991b1 Compare January 13, 2025 12:20
@live-github-bot live-github-bot bot added the automation CI/CD stuff label Jan 14, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch 2 times, most recently from 9cefe28 to d04dcbb Compare January 14, 2025 18:24
@live-github-bot live-github-bot bot added tools Has changes in tools and removed automation CI/CD stuff labels Jan 14, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch 2 times, most recently from 54de99a to 0f6b1c1 Compare January 15, 2025 09:23
@live-github-bot live-github-bot bot added the automation CI/CD stuff label Jan 15, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch from 0f6b1c1 to 769be20 Compare January 15, 2025 14:24
@live-github-bot live-github-bot bot removed tools Has changes in tools automation CI/CD stuff labels Jan 15, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch from 769be20 to bf1098f Compare January 15, 2025 15:05
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 15, 2025 •
edited
Loading

Desktop Bundle Checks

Comparing d07d25e against fc845bd.

🚀 tiny-secp256k1 library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing d07d25e against 4958893.

✅ Previous issues have all been fixed.

@thesan thesan mentioned this pull request Jan 16, 2025
Open
@live-github-bot live-github-bot bot added the tools Has changes in tools label Jan 20, 2025
@thesan thesan force-pushed the poc/asar-integrity-check branch from 6395e9d to 2cf8427 Compare January 20, 2025 17:37
@thesan thesan changed the title poc(lld): 🔒 ASAR integrity check feat(lld): 🔒 ASAR integrity check Jan 21, 2025
@thesan thesan marked this pull request as ready for review January 21, 2025 09:54
@thesan thesan requested a review from a team as a code owner January 21, 2025 09:54
@thesan thesan force-pushed the poc/asar-integrity-check branch from 52c6a1a to 4183ff8 Compare January 21, 2025 09:55
themooneer
themooneer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thesan thesan removed the Stale label Jan 21, 2025
@thesan thesan merged commit 03c5920 into develop Jan 21, 2025
53 checks passed
@thesan thesan deleted the poc/asar-integrity-check branch January 21, 2025 15:23
@jprudent jprudent mentioned this pull request Jan 23, 2025
Merged
thesan added a commit that referenced this pull request Jan 29, 2025
@thesan
Revert "feat(lld): 🔒 ASAR integrity check (#8748)"
3d9a545 
This reverts commit 03c5920.
@thesan thesan mentioned this pull request Jan 29, 2025
Merged
3 tasks
thesan added a commit that referenced this pull request Jan 29, 2025
@thesan
Revert "feat(lld): 🔒 ASAR integrity check (#8748)"
39f9692 
This reverts commit 03c5920.
@jprudent jprudent mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@thesan thesan

Labels
desktop Has changes in LLD tools Has changes in tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesan @themooneer