Skip to content

Commit

Permalink
Merge pull request #8963 from LedgerHQ/support/qaa_441_fix_playwright…
Browse files Browse the repository at this point in the history
…_schedule_run

[QAA-441][Specullos][Playwright] Fix scheduled run broadcast
  • Loading branch information
abdurrahman-ledger authored Jan 21, 2025
2 parents 4958893 + 26b1fc0 commit fc845bd
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test-mobile-e2e-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,6 @@ jobs:
uses: LedgerHQ/ledger-live/tools/actions/composites/setup-e2e-broadcast@develop
with:
enable_broadcast: ${{ inputs.enable_broadcast }}
schedule_cron: ${{ github.event.schedule.cron }}
- name: Run Android Tests
id: detox
run: pnpm mobile e2e:ci -p android -t $([[ "$INPUT_SPECULOS" == "true" ]] && printf %s '--speculos') $([[ "$PRODUCTION" == "true" ]] && printf %s '--production') --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test-ui-e2e-only-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ jobs:
uses: LedgerHQ/ledger-live/tools/actions/composites/setup-e2e-broadcast@develop
with:
enable_broadcast: ${{ inputs.enable_broadcast }}
schedule_cron: ${{ github.event.schedule.cron }}

- name: Run playwright tests [Linux => xvfb-run]
id: tests
Expand Down
6 changes: 1 addition & 5 deletions tools/actions/composites/setup-e2e-broadcast/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ inputs:
description: "Enable transaction broadcast"
required: false
default: "false"
schedule_cron:
description: "Cron expression for scheduled runs"
required: false
default: ""

runs:
using: composite
Expand All @@ -17,7 +13,7 @@ runs:
id: set-broadcast
shell: bash
run: |
if [[ "${{ inputs.enable_broadcast }}" == "true" || ( "${{ github.event_name }}" == "schedule" && "${{ inputs.schedule_cron }}" == "0 5 * * 1" ) ]]; then
if [[ "${{ inputs.enable_broadcast }}" == "true" || ( "${{ github.event_name }}" == "schedule" && "${{ github.event.schedule }}" == "0 5 * * 1" ) ]]; then
echo "DISABLE_TRANSACTION_BROADCAST=0" >> $GITHUB_ENV
else
echo "DISABLE_TRANSACTION_BROADCAST=1" >> $GITHUB_ENV
Expand Down

0 comments on commit fc845bd

Please sign in to comment.