Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin numpy Version Less Than 2.0.0 #191

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

numpy recently released version 2.0 which has a lot of changes. This PR matches Hatchet/140.

@ilumsden ilumsden requested review from pearce8 and ilumsden July 8, 2024 17:18
@ilumsden ilumsden added area-deployment Issues and PRs involving Thicket's packaging and deployment priority-high High priority issues and PRs labels Jul 8, 2024
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pearce8 this is ready for your review

@ilumsden ilumsden added the status-approved No more revisions are required on this PR and it is ready for merge label Jul 8, 2024
@ilumsden ilumsden changed the title Pin numpy Version Less Than 2.0.0 Temporarily pin numpy Version Less Than 2.0.0 Jul 8, 2024
@pearce8 pearce8 merged commit 8077c59 into LLNL:develop Jul 8, 2024
4 checks passed
michaelmckinsey1 added a commit to michaelmckinsey1/thicket that referenced this pull request Jul 9, 2024
michaelmckinsey1 added a commit to michaelmckinsey1/thicket that referenced this pull request Jul 9, 2024
Yejashi pushed a commit to TauferLab/thicket that referenced this pull request Sep 4, 2024
@slabasan slabasan added this to the 2024.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-deployment Issues and PRs involving Thicket's packaging and deployment priority-high High priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants