Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily pin numpy Version Less Than 2.0.0 #140

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Temporarily pin numpy Version Less Than 2.0.0 #140

merged 2 commits into from
Jul 8, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jul 8, 2024 •
edited
Loading

numpy recently released version 2.0 which has a lot of changes that break some of our unit tests.

@michaelmckinsey1 michaelmckinsey1 changed the title Pin numpy version less than 2.0.0 Pin numpy Version Less Than 2.0.0 Jul 8, 2024
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 8, 2024
@michaelmckinsey1 michaelmckinsey1 added area-ci Issues and PRs related to continuous integration processes used by Hatchet developers priority-normal Normal priority issues and PRs labels Jul 8, 2024
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review July 8, 2024 17:14
@michaelmckinsey1 michaelmckinsey1 requested a review from ilumsden July 8, 2024 17:14
@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Jul 8, 2024
Merged
@ilumsden ilumsden added area-deployment Issues and PRs involving Hatchet's packaging and deployment priority-high High priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed area-ci Issues and PRs related to continuous integration processes used by Hatchet developers priority-normal Normal priority issues and PRs labels Jul 8, 2024
@ilumsden ilumsden changed the title Pin numpy Version Less Than 2.0.0 Temporarily pin numpy Version Less Than 2.0.0 Jul 8, 2024
ilumsden
ilumsden approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pearce8 this is ready for your review

@ilumsden ilumsden added status-approved No more revisions are required on this PR and it is ready for merge and removed status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Jul 8, 2024
@pearce8 pearce8 merged commit a1f0a06 into LLNL:develop Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearce8 pearce8 pearce8 approved these changes

@ilumsden ilumsden ilumsden approved these changes

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-deployment Issues and PRs involving Hatchet's packaging and deployment priority-high High priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmckinsey1 @pearce8 @ilumsden