Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: moves re-exports of display_violinplot into the try-except-else guard #160

Merged
merged 2 commits into from
May 13, 2024

Conversation

ilumsden
Copy link
Collaborator

Fixes #158

To prevent issues with importing the optional seaborn dependency, all re-exports of "display" modules need to be placed in the else statement of the "try-except-else" guard in thicket/stats/__init__.py. However, the re-exports for display_violinplot.py were not placed in that else statement, which caused the import issues in #158.

This PR fixes this.

@ilumsden ilumsden added area-stats Issues and PRs related to Thicket's stats subpackage priority-urgent Urgent priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels May 13, 2024
@ilumsden ilumsden requested a review from pearce8 May 13, 2024 15:48
@ilumsden ilumsden self-assigned this May 13, 2024
@pearce8 pearce8 merged commit e107964 into LLNL:develop May 13, 2024
4 checks passed
@slabasan slabasan added this to the 2024.1.1 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-stats Issues and PRs related to Thicket's stats subpackage priority-urgent Urgent priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit dependency on seaborn when extra plotting is disabled
3 participants