-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refinements to display_violinplot_thicket Function #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this looks good, but there are two main issues that need to be addressed before I can approve.
9ff14bc
to
015d3b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
015d3b3
to
d829771
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
===========================================
+ Coverage 80.15% 80.19% +0.03%
===========================================
Files 52 52
Lines 3442 3448 +6
===========================================
+ Hits 2759 2765 +6
Misses 683 683
|
This PR improves the display_violinplot_thicket function in two ways:
Changed default xlabel to 'thicket' for clarity.
Restricted function to accept only the same node across all provided thickets.