Rework _unify #129
Merged
Rework _unify #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
changed the title
michaelmckinsey1
added
area-tests
|
Resolves #16 |
michaelmckinsey1
added
status-work-in-progress
michaelmckinsey1
added
status-ready-for-review
slabasan
force-pushed
the
fix-new_unify
branch
from
7e053a4 to
d2c268b
Compare
slabasan
approved these changes
Feb 15, 2024
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Mar 6, 2024
* Replace _sync_nodes and _sync_nodes_frame * Perform union every time to correctly keep nodes up-to-date * Add unit test and add literal reader for test * Add docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rework the
_unifyfunction to leverage theold_to_newobject returned bygraph.union()to more cleanly keep track of node updates during the unification process. Currently we update everything afterwards using_sync_nodes_frame, which requires some assumptions about the structure of the data. These implicit assumptions have resulted in bugs from our users. By leveraging the node map returned by the union function, we do not have to make any assumptions, which will reduce the amount of bugs we encounter.Changes
_unifyfunction_sync_nodesand_sync_nodes_framePerformance Impact
Where
n=len(thickets):The current code unify is approx
O(n+n)for computing unionsnand sync nodes time (approxn). The new code adds a loop in each union step that makes the union block nowO(n^2). new-v2 and new-v3 are optimizations on the naive implementation of "new".Small study
Current data line of best fit is linear (
Y = 0.07X + -1.73)New data line of best fit is nlog(n) (
Y = -123 + .5X*log_10(X)). Empirically this is nlog(n) but if we had a worst case example at each size with n distinct graphs (improbable) I imagine it could actually fit n^2.