-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Progress Bar to Reader #131
Conversation
|
47ef513
to
c786f2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelmckinsey1 Two things: (1) Can you take a look at the conflicting file? (2) What do you think about setting disable_tqdm=True in our unit tests? For one, it'll show an example of using the new parameter, and also unit tests are small enough that we don't need to be showing progress. Not sure how this will render in our static jupyter notebook outputs in RTD, but maybe we disable it there as well.
19bf55c
to
1c5413c
Compare
|
d92a8a1
to
4fea8f3
Compare
Summary
Use
tqdm
to add a progress bar to the thicket reader since for larger amount of files (~1000+) in can take in the magnitude of minutes without any indication to the user (we don't want it to seem like it's hanging). The progress bar is in 2 stages for reading the files, and creating the thickets.