Use both macos targets in ui-showcase #3663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR;
This is needed because of the issue with rendering expect/actual. I would propose for now to just add
macosArm64
target and resolve underlying issue during implementation of #3386 for Dokka K2. We will anyway need to do something with such sourceSets.In #3662 test started to fail on

ui-showcase
module because ofERROR CLASS
.Checking the page where the fail happened, I found that for some reason
ui-showcase
currently (onmaster
) doesn't contain an actual declaration formacos
sourceSet:asyncWithDelay
doesn't havemacos
tab, butactual
declaration exists in sourceSet.If we run the same test with the changes from #3662,

macos
tab is now appeared but showsERROR CLASS
:All other declarations of
asyncWithDelay
for other sourceSets look the same as before.Also, other declarations (which don't depend on

coroutines
) likegetCurrentDate
which also hasexpect/actual
defined in the same - work fine onmaster
andmacos
tab exist:Most probably the issue is very similar to #3386 (even though problem described here reproducible on K1).
If we build
ui-showcase
with Dokka K2:master
-linux
andmacos
are not shown at all forasyncWithDelay
.internal expect
butpublic actual
declarations #3662 - all source sets are shown but bothlinux
andmacos
will showERROR CLASS
macosArm64
target (as in this PR) -macos
source set will be shown.