-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DGPv2 example projects #3820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
atyrin
reviewed
Sep 23, 2024
atyrin
approved these changes
Sep 24, 2024
whyoleg
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
just some small questions/remarks
examples/gradle-v2/kotlin-multiplatform-example/build.gradle.kts
Outdated
Show resolved
Hide resolved
examples/gradle-v2/kotlin-multiplatform-example/build.gradle.kts
Outdated
Show resolved
Hide resolved
examples/gradle-v2/kotlin-multiplatform-example/build.gradle.kts
Outdated
Show resolved
Hide resolved
- Convert the existing DGPv1 examples to demonstrate DGPv2. - Import [Dokkatoo examples](https://github.com/adamko-dev/dokkatoo/tree/v2.4.0/examples). Part of KT-71346 To keep the PR smaller, tests to ensure these projects work as expected will be added in a following PR.
Co-authored-by: Oleg Yukhnevich <whyoleg@gmail.com>
…is easy to confuse with the Dokka HTML/Javadoc output formats.
bfb815c
to
3c32c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
An issue/PR related to Dokka's external or internal documentation
runner: Gradle plugin
An issue/PR related to Dokka's Gradle plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of KT-71346
To keep the PR smaller, tests to ensure these projects work as expected will be added in a separate PR #3820.