Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DGPv2 example projects #3820

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Conversation

adam-enko
Copy link
Member

@adam-enko adam-enko commented Sep 23, 2024

  • Convert the existing DGPv1 examples to demonstrate DGPv2.
  • Import Dokkatoo examples.

Part of KT-71346

To keep the PR smaller, tests to ensure these projects work as expected will be added in a separate PR #3820.

@adam-enko adam-enko added runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin documentation An issue/PR related to Dokka's external or internal documentation labels Sep 23, 2024
@adam-enko adam-enko added this to the Dokka 2.0.0 milestone Sep 23, 2024
@adam-enko adam-enko requested review from whyoleg and atyrin September 23, 2024 11:44
@atyrin atyrin self-requested a review September 24, 2024 11:01
Copy link
Collaborator

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

just some small questions/remarks

adam-enko and others added 11 commits September 24, 2024 16:49
- Convert the existing DGPv1 examples to demonstrate DGPv2.
- Import [Dokkatoo examples](https://github.com/adamko-dev/dokkatoo/tree/v2.4.0/examples).

Part of KT-71346

To keep the PR smaller, tests to ensure these projects work as expected will be added in a following PR.
Co-authored-by: Oleg Yukhnevich <whyoleg@gmail.com>
…is easy to confuse with the Dokka HTML/Javadoc output formats.
@adam-enko adam-enko force-pushed the adam/feat/KT-70336/add-gradle-v2-examples branch from bfb815c to 3c32c89 Compare September 24, 2024 14:49
@adam-enko adam-enko merged commit 2c2db32 into master Sep 24, 2024
29 checks passed
@adam-enko adam-enko deleted the adam/feat/KT-70336/add-gradle-v2-examples branch September 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue/PR related to Dokka's external or internal documentation runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants