-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Artifacts.toml
files for our fake JLL packages
#38070
Conversation
These don't do anyhting except play nicely with other tools that expect to find `Artifacts.toml` files within JLL package directories, like BB.
This seems to break Pkg CI on AppVeyor: https://ci.appveyor.com/project/JuliaLang/pkg-jl/builds/35900697. It keeps failing with complaints about not being able to install artifacts for LibCURL_jll or MozillaCACerts_jll. |
I was just about to make a PR to delete those files (9125bbb) because they are not used by the packages, and cause artifacts downloads for e.g. |
As Fredrik says, they do in fact do something, they cause Pkg to try download those artifacts when the stdlib is added. |
Would marking all the artifacts as lazy help? The future plan, I believe, is to actually provide these as artifacts, which would prevent Pkg from downloading them, but we haven't merged the change for that yet. |
Yes, that would make them not be downloaded. They were added because other parts of the infrastructure expects them but maybe they are fine with them being lazy. |
This avoids `Pkg` from finding the `Artifacts.toml` for these stdlibs (which already have their binaries bundled with Julia, so no need to download the actual artifacts) while still allowing other tools (such as BinaryBuilder) to find the binaries in a structured manner. Fixes #38070 (comment)
I think just naming the file to something else is a fine solution; BB (and other tools) can be taught to look in another filename I think. |
That seems drastic for what seems like a temporary problem, no? Won't this issue go away once we're using actual JLLs for Julia's own dependencies? At that point the JLLs will already be installed (in the read-only system depot), so this wouldn't be a problem anymore. |
Yes; but that's not going to happen until v1.7. |
Ah, ok. I forgot about that and thought it was still happening in 1.6. |
These don't do anyhting except play nicely with other tools that expect
to find
Artifacts.toml
files within JLL package directories, like BB.