PlatformEngines: use Tar.jl for tarball operations #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/PlatformEngines3
branch
2 times, most recently
from
ba668b5 to
7f415f1
Compare
|
Hard to tell if the AppVeyor failures are because I broke something or just network flakiness. |
|
I don't believe that the AppVeyor CI failure is caused by this change, I think it's caused by JuliaLang/julia#38070. |
StefanKarpinski
force-pushed
the
sk/PlatformEngines3
branch
from
7f415f1 to
e637787
Compare
StefanKarpinski
force-pushed
the
sk/PlatformEngines3
branch
from
e637787 to
ff01286
Compare
|
What was the Windows problem in the end? |
KristofferC
reviewed
Oct 24, 2020
| @@ -888,19 +365,10 @@ end | |||
| Compress `src_dir` into a tarball located at `tarball_path`. | |||
| """ | |||
| function package(src_dir::AbstractString, tarball_path::AbstractString) | |||
There was a problem hiding this comment.
This is also test only, right?
There was a problem hiding this comment.
Not sure, I thought the Artifacts code used it too, but I could be wrong.
|
This broke system 7z build! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest installment in my quest to make the name "PlatformEngines" increasingly nonsensical. As a practical matter,
Tar.jlsets permissions correctly when extracting tarballs, which7zdoes not, so this fixes an actual bug. This PR doesn't implement it butTar.tree_hashwill also allow us to reliably verify tree hashes before extracting tarballs, so we can actually protect against incorrect tarball content, even on broken file systems.