-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe #317: Image in annotations #114
Comments
Hello @lpoujade, I am not 100% if we always stick to this convention, but in your title "Image in annotations" the word 'annotations' may need to be capitalized. This phrase gets a bit circular and what image being mentioned isn't very clear.
Perhaps something like "we have two separate objects that make up the Annotation body. One object is an image which is the supplementary image and the other is a textual body which acts as a caption for the supplementary image. Both of these objects together target the image from the Canvas." One more small touch up. This instance of "canvas" should be capitalized.
|
@thehabes's comment reminded me that I had a comment on the recipe title. It's a bit vague - what about changing the title to something like "Annotating a Resource with an Image"? Also, a few edits for style/grammar: The first sentence (that vs. which; use of prepositions) - maybe something like: "Provide an image that adds details about or shows a different view of a particular feature/area of the Resource." The second bullet point: should have a comma between "built" and "So", not a full stop. This will mean a lot of commas/clauses in that sentence, so maybe revise - something like: "To show how the completed building looks, you decide to annotate specific features, such as the patio, with actual photographs." The third bullet point:
The Implementation notes section, last line: "provides" should edited to "provide" |
Just a quick remark about the size of the image in the annotation (3024x4032, 9,72 Mo), so not ideal in terms of performance and best practices (given the fact that this image is mostly intended to be displayed in a small box on top of the main image, or in a sidebar) |
@regisrob you are totally right, I'll change the image for a lighter one ! @thehabes @kirschbombe thank for remarks, as you may have guessed I am not a native english speaker, I will rephrase using your hints 😁 |
Issue 114 (Recipe #317: Image in annotations)+1: 21 [akrishnan15 cubap danieltbrennan dlpierce eliotjordan glenrobson hadro ioanrichards irv jpadfield jtweed julsraemy kirschbombe markpatton markpbaggett nfreire regisrob robcast thehabes tpendragon triplingual] Result: 21 / 21 = 1.00Super majority is in favor, issue is approved |
I updated the recipe with all your suggested changes except for:
|
Links
Background and Summary
This recipe shows how to annotate an image onto a canvas with a
commenting
motivation rather than apainting
motivation. A number of use cases are presented in the recipe but this recipe builds on previous text based annotations to show how this can be extended with an image in the body of the annotation.Voting and changes
We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.
If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.
Changes to the recipe will only be made after the TRC voting process has concluded.
The text was updated successfully, but these errors were encountered: