-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example for an image in annotation #392
Conversation
4ae7e31
to
300f862
Compare
Your preview did build! It is at https://preview.iiif.io/cookbook/377-image-in-annotation/recipe/377-image-in-annotation/ |
Sorry @lpoujade I forgot to paste out comments into this pull request but we had a look at your recipe in the call last week and noted the following: Use case
Implementation note
Restrictions
Example
Also could you add a link to this recipe in the following file: https://github.com/IIIF/cookbook-recipes/blob/377-image-in-annotation/index.md and also in the links.md (note the number is the issue id so 00377 in this case). |
Thank you @glenrobson ! I have seen the comments on the google doc but didn't had enough time to update my pr. I'll try to do it before the next cookbook call About the layer recipe, I assume you are talking about this one ? |
- added use case examples - removed Mirador as it doesn't show the image from the annotation - added new recipe link to index/links page
Hi, I updated my PR but got some questions:
And about the different ways this can be done in IIIF, I'll have to search a bit ! |
This works in Annona for any id field now. Also the caption and attribution fields are |
Cool! Glad it could help :) |
c5e7391
to
eb2e8d2
Compare
+ removed useless content
eb2e8d2
to
99ef756
Compare
The cookbook editors have reviewed your recipe and requested the following changes:
With the above changes the editors are happy for it to go to the TRC for final review. Would you be able to make the above changes by next Wednesday? Thanks |
minor corrections, some casual language revisions as discussed in the CBEditors meeting
Yes I can update my PR next week
Le 27 avril 2023 15:48:07 GMT+02:00, Glen Robson ***@***.***> a écrit :
…The cookbook editors have reviewed your recipe and requested the following changes:
* Could you add an 's' to annotations in the title: "Image in annotations" (this is to match the HTML in annotations recipe)
* Patrick is going to leave notes on the pull request regarding a few small language issues in the use case
* Could you remove the !!! marks from the Tagging with an external resource link in the related recipes.
* Could you remove the sub bullets in the related recipes and move the text next to the link so it looks similar to the related recipes in: https://iiif.io/api/cookbook/recipe/0019-html-in-annotations/
With the above changes the editors are happy for it to go to the TRC for final review. Would you be able to make the above changes by next Wednesday?
Thanks
--
Reply to this email directly or view it on GitHub:
#392 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Follow up of #377 , opened a pull request to generate the preview, which is accessible here
It probably miss something cause I don't see my recipe on this page
Also, I don't know what to put in the Restrictions part