Merge dev into master #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update eslint and prettier * add husky * update package.json and configs * fix pre-commit script * add spell checker * enable no-param-reassign * update eslint * update eslint
* update eslint and prettier * add husky * update package.json and configs * linted-files * fix no-param-reassign rule * update eslint * update comment * fix misprint * SC-2384: Add linter and husky to server repo / Update aliases (#48) * update aliases * update default alias * add spell check fixes * solve eslint errors
– The tests showed that hub-spot deals were created without duplicates. – Added deal ID to have a link to the offer ID from hub-spot – Removed associations
* Update lodash imports. * Add rule for restrict direct lodash import. --------- Co-authored-by: Andrii Zinko <andrii.zinko@sysgears.com>
* Implement utility for omitting dependency ids in offer request questions. * Lint files. Improve omit dependency ids utility typing. * Rewrite get changed function to return boolean values. * Add rule for importing functions from lodash. * Create lodash internal functions aggregator. * Update imports for lodash. * Update eslint rules. * Removed unnecessary options property check in omit dependency ids utility. * Update eslint rules for eslint comments. * Improve lodash import in round to step utility. * Improve eslint-disable comment for lodash functions aggregator. * Revert eslint rules creating. * Revert creating lodash imports aggregator. Improve function and variable naming. * Update have changed questions function name, type and related file names. * Use one type of name. * Remove import/extensions disabling. * Rename files. --------- Co-authored-by: Andrii Zinko <andrii.zinko@sysgears.com>
* Add backward compatibility for chat subscriptions * Add deprecation warning to the description --------- Co-authored-by: Nikita Bereziuk <nikita.bereziuk@sysgears.com>
bnwebdev
requested review from
a team,
AndrewZinko,
anhromovyi,
medreres,
DmytroLaikov and
dmytroipatov
and removed request for
a team
|
That PR waits merging of #57 |
Change lodash isNumber to last function Co-authored-by: Nikita Bereziuk <nikita.bereziuk@sysgears.com>
dmytroipatov
approved these changes
Sep 18, 2023
AndrewZinko
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.