Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-2383: Approve changes popup #49

Merged
merged 18 commits into from
Sep 18, 2023
Merged

SC-2383: Approve changes popup #49

merged 18 commits into from
Sep 18, 2023

Conversation

AndrewZinko
Copy link
Contributor

@AndrewZinko AndrewZinko self-assigned this Sep 15, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #2383: Approve changes popup.

DmytroLaikov
DmytroLaikov previously approved these changes Sep 15, 2023
View reviewed changes
DmytroLaikov
DmytroLaikov previously approved these changes Sep 15, 2023
View reviewed changes
bnwebdev
bnwebdev suggested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@bnwebdev bnwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you split the task-related changes and refactoring PRs in the future

@dmytroipatov
Copy link
Contributor

Good work with the lodash imports!

medreres
medreres suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@medreres medreres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

medreres
medreres previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@medreres medreres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

dmytroipatov
dmytroipatov suggested changes Sep 18, 2023
View reviewed changes
dmytroipatov
dmytroipatov previously approved these changes Sep 18, 2023
View reviewed changes
@anhromovyi anhromovyi merged commit 05abbea into dev Sep 18, 2023
@anhromovyi anhromovyi deleted the andriizinko/sc-2383/approve-changes-popup branch September 18, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnwebdev bnwebdev bnwebdev approved these changes

@medreres medreres medreres approved these changes

@dmytroipatov dmytroipatov dmytroipatov approved these changes

@DmytroLaikov DmytroLaikov DmytroLaikov left review comments

@anhromovyi anhromovyi Awaiting requested review from anhromovyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndrewZinko @dmytroipatov @anhromovyi @bnwebdev @medreres @DmytroLaikov