Skip to content
This repository was archived by the owner on May 25, 2024. It is now read-only.

Use mixins accessors + some misc fixes #77

Merged
merged 28 commits into from
Jun 15, 2023
Merged

Use mixins accessors + some misc fixes #77

merged 28 commits into from
Jun 15, 2023

Conversation

kuba6000
Copy link
Member

@kuba6000 kuba6000 marked this pull request as draft June 15, 2023 10:09
@kuba6000 kuba6000 marked this pull request as ready for review June 15, 2023 11:12
@kuba6000 kuba6000 requested review from a team June 15, 2023 11:12
@miozune
Copy link
Member

miozune commented Jun 15, 2023

It would be better to pass formatted decimal string to translator method than mixining into vanilla. It has an advantage of utilizing DecimalFormat for more detailed configuration.
Example: https://github.com/GTNewHorizons/GTNEIOrePlugin/blob/749ee1a1860b65ef516d97224aad964b68bfbe09/src/main/java/pers/gwyog/gtneioreplugin/plugin/gregtech5/PluginGT5UndergroundFluid.java#L104

@kuba6000
Copy link
Member Author

It would be better to pass formatted decimal string to translator method than mixining into vanilla. It has an advantage of utilizing DecimalFormat for more detailed configuration. Example: https://github.com/GTNewHorizons/GTNEIOrePlugin/blob/749ee1a1860b65ef516d97224aad964b68bfbe09/src/main/java/pers/gwyog/gtneioreplugin/plugin/gregtech5/PluginGT5UndergroundFluid.java#L104

Maybe, but my mixin is also working and I can just use StatCollector.translateToLocalFormatted or String.format with number formatting from lang file for a simple text.

@miozune
Copy link
Member

miozune commented Jun 15, 2023

Hmm, I don't like it, but it won't harm other mods, so it's fine I guess

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubatech's WorldMixin will produce a huge number of CallbackInfoReturnable objects EIG bug with Glieonia
2 participants