-
Notifications
You must be signed in to change notification settings - Fork 16
Use mixins accessors + some misc fixes #77
Conversation
kuba6000
commented
Jun 15, 2023
- Use mixins accessors instead of reflections
- Fixes Kubatech's WorldMixin will produce a huge number of CallbackInfoReturnable objects GT-New-Horizons-Modpack#13699
- Fixes EIG bug with Glieonia GT-New-Horizons-Modpack#12021
- Fix very long floating point numbers on some mobs in mob handler (translation fix)
- Some other internal mod changes
src/main/java/kubatech/mixin/mixins/InfernalMobs/InfernalMobsCoreAccessor.java
Outdated
Show resolved
Hide resolved
src/main/java/kubatech/mixin/mixins/minecraft/StringTranslateMixin.java
Outdated
Show resolved
Hide resolved
It would be better to pass formatted decimal string to translator method than mixining into vanilla. It has an advantage of utilizing |
Maybe, but my mixin is also working and I can just use StatCollector.translateToLocalFormatted or String.format with number formatting from lang file for a simple text. |
Hmm, I don't like it, but it won't harm other mods, so it's fine I guess |