Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubatech's WorldMixin will produce a huge number of CallbackInfoReturnable objects #13699

Closed
3 tasks done
wohaopa opened this issue Jun 14, 2023 · 0 comments · Fixed by GTNewHorizons/KubaTech#77
Closed
3 tasks done
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Lag Issue causes TPS or FPS lag

Comments

@wohaopa
Copy link
Contributor

wohaopa commented Jun 14, 2023

Your GTNH Discord Username

No response

Your Pack Version

2.3.2

Your Server

forge server

Java Version

Java 8

Type of Server

Vanilla Forge

Your Expectation

I found something wrong with memory like this
%6Y3%OK J)79A8%7UH_4LOC
Then I realized that I had a huge amount of CallbackInfoReturnable objects in memory
image
Then I used mixin debug to find this
image

It's on github here

World.getBlock() is a hot method that gets called frequently in the main tick. I think we should use something else instead of this Mixin injection

The Reality

:(

Your Proposal

Use something else instead of this injection. :)

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@wohaopa wohaopa added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Jun 14, 2023
@miozune miozune added Type: Lag Issue causes TPS or FPS lag Mod: KubaTech labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Lag Issue causes TPS or FPS lag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants