Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Structural output login google #2106

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1866

Test Plan

How do we know the code works?

All outputs logs and behavior of command flank auth login works like previously

@github-actions
Copy link
Contributor

Timestamp: 2021-07-27 19:59:59
Buildscan url for ubuntu-workflow run 1072499904
https://gradle.com/s/gbjuwxgsmla6a

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the use of Flow + Sealed interfaces 👍

@mergify mergify bot merged commit a09259d into master Jul 28, 2021
@mergify mergify bot deleted the 1866_refactor_output_google_login branch July 28, 2021 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structural output - LoginGoogleAccount
3 participants