We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
According to the description of epic #1728, prepare a specification document for the structural output based on the following requirements:
out
Make sure that specification is sufficient to implement structured output without a doubt.
LoginGoogleAccount
The text was updated successfully, but these errors were encountered:
Printing URL to loginUserAuth#L92-93
UserAuth#L92-93
logLn("Visit the following URL in your browser:") logLn(url)
`
User token saved ftl.client.google.UserAuth#L118-119
ftl.client.google.UserAuth#L118-119
logLn() logLn("User token saved to $userToken")
sealed interface LoginState { data class LoginStarted(val url: String) : LoginState data class LoginFinished(val tokenLocation: String) : LoginState }
UserAuth#requestmethod will return Flow<LoginState>
UserAuth#request
Flow<LoginState>
api contract will be changed from
object UserAuthorization { interface Request : () -> Unit }
to
object UserAuthorization { interface Request : () -> Flow<LoginState> }
LoginGoogleAcount#invoke will observe new flow and pass all collected LoginStateto out() function
LoginGoogleAcount#invoke
LoginState
out()
LoginCommandwill be responsible for printing correct message based on the LoginState
LoginCommand
Sorry, something went wrong.
refactor: Structural output login google (#2106)
a09259d
Fixes #1866 ## Test Plan > How do we know the code works? All outputs logs and behavior of command `flank auth login` works like previously
piotradamczyk5
Successfully merging a pull request may close this issue.
Plan
According to the description of epic #1728, prepare a specification document for the structural output based on the following requirements:
out
function reference to low-level functions that producing logs.Make sure that specification is sufficient to implement structured output without a doubt.
Command
LoginGoogleAccount
The text was updated successfully, but these errors were encountered: