OpcodeDispatcher: Use offset for LRCPC2 more frequently #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
4216_#2
branch
from
b0d691d to
224b683
Compare
alyssarosenzweig
approved these changes
Feb 10, 2025
This was in an assert statement which wouldn't give us the offset.
We were missing small offset immediate encoded LRCPC2 pretty much always. This fixes that. Finishes up what FEX-Emu#4216 started.
Sonicadvance1
force-pushed
the
4216_#2
branch
from
224b683 to
6728055
Compare
|
Rebased to fix instcountci conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing small offset immediate encoded LRCPC2 pretty much
always.
This fixes that. Finishes up what #4216 started.