Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location Permission for Desktop #57660

Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
71a1efd
fix permission from in desktop
wildan-m Feb 11, 2025
a6aab02
Add loading spinner to button when confirming
wildan-m Feb 11, 2025
614bb06
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Feb 12, 2025
52c289d
Resolve conflict
wildan-m Feb 12, 2025
5784e16
pre-fetch location
wildan-m Feb 12, 2025
c36d808
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Feb 13, 2025
9ffbc71
clear user location for prefetch
wildan-m Feb 14, 2025
302b1e3
fix incorrect long lat assignment
wildan-m Feb 14, 2025
8db0bb2
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Feb 26, 2025
8af7e50
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Feb 27, 2025
eea3a21
revert unnecessary changes
wildan-m Feb 27, 2025
7489faf
listen is visible change when refocus window
wildan-m Feb 27, 2025
7baaebb
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Feb 28, 2025
40b3124
check location permission periodically and when re-focus
wildan-m Feb 28, 2025
92e78dd
Remove app relaunch
wildan-m Feb 28, 2025
964c9fa
handle web issue
wildan-m Feb 28, 2025
e323b7b
Fix desktop and web
wildan-m Feb 28, 2025
bd0da9d
remove desktop specific code
wildan-m Mar 1, 2025
73bf311
prettier lint, WIP mweb
wildan-m Mar 1, 2025
0c5de91
Lint & prettier
wildan-m Mar 3, 2025
383b288
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Mar 3, 2025
459467d
Fix lint
wildan-m Mar 3, 2025
3e7bf42
remove unnecessary code, add comment
wildan-m Mar 3, 2025
3500f6a
Add comment for new use effect
wildan-m Mar 3, 2025
7dc9f8e
prettier
wildan-m Mar 3, 2025
2abb0a0
Update src/pages/iou/request/step/IOURequestStepScan/index.tsx
wildan-m Mar 4, 2025
771ee77
Update desktop/ELECTRON_EVENTS.ts
wildan-m Mar 4, 2025
be69a58
Update src/components/LocationPermissionModal/index.tsx
wildan-m Mar 4, 2025
822bc01
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Mar 4, 2025
c328cbc
remove unnecessary code
wildan-m Mar 4, 2025
3c223f9
remove unnecessary argument
wildan-m Mar 4, 2025
4707278
remove open setting for non mac desktop
wildan-m Mar 4, 2025
463c3d3
add loading feedback after user clicking continue/setting button
wildan-m Mar 4, 2025
9d6b488
more specific prop comment
wildan-m Mar 4, 2025
b017d3a
make desktop specific code for LocationPermissionModal
wildan-m Mar 4, 2025
f14fa25
prettier & lint
wildan-m Mar 4, 2025
b7ffed7
restore setShowModal position
wildan-m Mar 4, 2025
f0646b5
Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…
wildan-m Mar 5, 2025
f15e586
remove unused code
wildan-m Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restore setShowModal position
  • Loading branch information
wildan-m committed Mar 4, 2025
commit b7ffed72cf52e7a5bc44da94e1774321d5d10f78
3 changes: 1 addition & 2 deletions src/components/LocationPermissionModal/index.tsx
Original file line number Diff line number Diff line change
@@ -74,7 +74,6 @@ function LocationPermissionModal({startPermissionFlow, resetPermissionFlow, onDe
if (hasError) {
if (Linking.openSettings) {
Linking.openSettings();
setShowModal(false);
} else {
// check one more time in case user enabled location before continue
getLocationPermission().then((status) => {
@@ -84,8 +83,8 @@ function LocationPermissionModal({startPermissionFlow, resetPermissionFlow, onDe
onDeny?.();
}
});
setShowModal(false);
}
setShowModal(false);
return;
}
cb();