Fix location Permission for Desktop

[wildan-m]

Explanation of Change

Prompt settings for desktop when the location service not enabled and automatically hide LocationPermissionModal when it's enabled

Fixed Issues

$ #52668
PROPOSAL: #52668 (comment)

Tests

Pre-condition

1. Reset App/Site Permission

Desktop

1. System Settings > Privacy & Security
2. Disable Location Services for the following app:

• Electron (For Dev)
• New Expensify (For Staging)

Web Chrome

Access chrome://settings/content/location

Search staging.new.expensify.com, dev.new.expensify.com:8082
Remove delete the entries to reset the permission (if any)

Chrome mWeb

Settings > Advanced > Site settings > Location, then remove expensify sites entry

Native iOS

Real Device
Open Settings:

• Go to the Settings app on your iPhone or iPad.
  Navigate to Privacy Settings:
• Scroll down and tap Privacy (or "Privacy & Security" depending on your iOS version).
• Tap Location Services.
  Find Expensify
  Reset Permission:
• You’ll see options like "Never," "Ask Next Time," "While Using the App," or "Always." There’s no direct "reset" button for individual apps, but changing it to Ask Next Time (if available) ensures the next website you visit in Safari that requests location will prompt you again as if it’s the first time.

iOS Simulator

Execute in terminal

xcrun simctl privacy booted reset all com.expensify.chat
xcrun simctl privacy booted reset all com.expensify.chat.dev

safari iOS

Real Device
Open Settings:

• Go to the Settings app on your iPhone or iPad.
  Navigate to Privacy Settings:
• Scroll down and tap Privacy (or "Privacy & Security" depending on your iOS version).
• Tap Location Services.
  Find Safari:
• Scroll through the list of apps until you see Safari Websites (not just "Safari"—this specifically controls location access for websites within Safari).
• Tap Safari Websites.
  Reset Permission:
• You’ll see options like "Never," "Ask Next Time," "While Using the App," or "Always." There’s no direct "reset" button for individual apps, but changing it to Ask Next Time (if available) ensures the next website you visit in Safari that requests location will prompt you again as if it’s the first time.

iOS Simulator
xcrun simctl privacy booted reset all com.apple.mobilesafari

Native Android

1. Open Settings .
2. Tap Location .
3. Tap App location permissions.
4. Under 'Allowed all the time,' 'Allowed only while in use,' 'Ask every time,' and 'Not allowed,' find the apps that can use your device's location, change to Ask every time

2. Reset nvp_lastLocalPermissionPrompt key

Settings > Troubleshoot > Clear cache and restart or if you a developer, you can selectively reset this onyx key Onyx.merge('nvp_lastLocalPermissionPrompt', null)

3. Create a workspace
4. Dev only. If we want to test in local ensure GCP_GEOLOCATION_API_KEY correctly configured in the .env

Steps:

Desktop

1. Launch Expensify App
2. Navigate to the workspace chat
3. Select the option to Submit expense > Scan receipt
4. Select the option to upload a receipt
5. Upload a receipt file
6. Click the "Submit expense" button
7. Verify that the confirm button will be changed to loading indicator
8. Wait until the Location Permission Modal shown (15 seconds)
9. Click Settings
10. Verify OS location setting shown
11. Enable location settings
12. Go back to the expensify app
13. Verify that the location permission modal dismissed
14. Verify that the request submitted
15. If you are developer, verify that RequestMoney API request include receiptGpsPoints in the payload (Tips: Find console log with [info] [API] Called API write - {"command":"RequestMoney" prefix)
16. Repeat steps 2 - 6
17. Verify that second attempt to request money success and doesn't show Location Permission Modal
18. If you are developer, Verify that the second request created with receiptGpsPoints in the payload.

Web/mWeb Chrome / Native Ios / Native Android

1. Launch Expensify App
2. Navigate to the workspace chat
3. Select the option to Submit expense > Scan receipt
4. Select the option to upload a receipt
5. Upload a receipt file
6. Click the "Submit expense" button
7. Verify that the confirm button will be changed to loading indicator
8. Wait until the Location Permission Modal shown
9. Click Continue
10. Verify Browser location prompt shown
11. Click Allow while visiting the App / Allow while using App / Allow while visiting this site
12. Verify that the location permission modal dismissed
13. Verify that the request submitted
14. If you are developer, verify that RequestMoney API request include receiptGpsPoints in the payload (Tips: Find console log with [info] [API] Called API write - {"command":"RequestMoney" prefix)
15. Repeat steps 2 - 6
16. Verify that second attempt to request money success and doesn't show Location Permission Modal
17. If you are developer, Verify that the second request created with receiptGpsPoints in the payload.

• Verify that no errors appear in the JS console

Note

In the safari mWeb, the location permission modal will always be shown, even when the location is enabled; this is a known separate issue.

Offline tests

Same as test

QA Steps

Same as test

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Kapture.2025-03-03.at.11.42.20.mp4

Android: mWeb Chrome

Kapture.2025-03-03.at.12.00.34.mp4

iOS: Native

Kapture.2025-03-03.at.11.16.39.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Kapture.2025-03-03.at.10.51.18.mp4

MacOS: Desktop

Kapture.2025-03-03.at.10.37.24.mp4

[melvin-bot]

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[wildan-m]

Update

Most of the requested changes has been applied.

I have encountered an issue in Safari mWeb where the location permission modal always appears, even though it was previously allowed. I am unable to debug Safari mWeb at the moment due to a similar issue in Slack.

[luacmartins]

Thanks for the update @wildan-m! Let us know once you've been able to address the mWeb safari issue

[c3024]

@wildan-m

I had the same problem. It worked for me when I opened the console in Safari with the staging website on the iOS simulator and then opened the dev link in the same tab.

[c3024]

I have encountered an issue in Safari mWeb where the location permission modal always appears, even though it was previously allowed.

It is the same on staging too. It appears to be an iOS Safari quirk that cannot be easily fixed. I think we should handle it separately.

Screen.Recording.2025-03-05.at.11.14.00.AM.mov

[luacmartins]

Sounds good. Let's continue with review here then

[c3024]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

locationAndroid.mov

Android: mWeb Chrome

locationAndroidmWeb.mov

iOS: Native

locationiOS.mov

iOS: mWeb Safari

locationiOSmWeb.mov

MacOS: Chrome / Safari

locationChrome.mov

MacOS: Desktop

locationDesktop.mov

[c3024]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌