Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only bind a single Keyboard.addListener('keyboardDidShow') event #567

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

marcaaron
Copy link
Contributor

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/141694

Tests (Android is where the original issue was reproduced)

  1. Send yourself a message from another account
  2. Open the Android app
  3. Verify that any unread chats in the LHN are still unread

Screenshots

…ide bar links instead of completely re-rendering them which is expensive.
@marcaaron marcaaron self-assigned this Sep 30, 2020
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 👍

@AndrewGable AndrewGable merged commit 87d004f into master Sep 30, 2020
@AndrewGable AndrewGable deleted the marcaaron-fixDisappearingChats branch September 30, 2020 20:49
@MelvinBot MelvinBot mentioned this pull request Jun 23, 2023
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants