Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb - Room - Whisper is not shown for mention added while edit comment #45496

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 16, 2024 · 23 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4724888
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a room report
  3. Enter jaihanumanblog@gmail.com
    Only bind a single Keyboard.addListener('keyboardDidShow') event #567 (email id and random room mention)
  4. Send the message
  5. Note whisper message is shown
  6. Long press the comment and select edit comment
  7. Enter jaihanumanblog+6788@gmail.com
    [CP Staging] revert 56316 #56778 (email id and random room mention)
  8. Send the message

Expected Result:

Whisper must be shown for mention added while edit comment

Actual Result:

Whisper is not shown for mention added while edit comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543563_1721114547362.Sc._bh.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01490add6334f2b67a
  • Upwork Job ID: 1813353966729699916
  • Last Price Increase: 2024-07-16
Issue OwnerCurrent Issue Owner: @marcochavezf
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@JmillsExpensify
Copy link

Yes, that's correct. Opening up to the community.

@JmillsExpensify JmillsExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01490add6334f2b67a

@melvin-bot melvin-bot bot changed the title mWeb - Room - Whisper is not shown for mention added while edit comment [$250] mWeb - Room - Whisper is not shown for mention added while edit comment Jul 16, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

@Tony-MK
Copy link
Contributor

Tony-MK commented Jul 17, 2024

@JmillsExpensify and @suneox, I believe this issue should handled in the back end because the updateComment response does not include the "ACTIONABLEREPORTMENTIONWHISPER" action like the AddComment response.

Could we check this in the back end?

Thanks

@suneox
Copy link
Contributor

suneox commented Jul 17, 2024

@JmillsExpensify and @suneox, I believe this issue should handled in the back end because the updateComment response does include the "ACTIONABLEREPORTMENTIONWHISPER" action like the AddComment response.

@Tony-MK Thank you for your investigate, I'll be check in few hours

@suneox
Copy link
Contributor

suneox commented Jul 17, 2024

I have double-checked that the updateComment API doesn’t update the message content for actionName is ACTIONABLEREPORTMENTIONWHISPER. Therefore, I think this issue should be moved to internal.

🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Jul 17, 2024

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@marcochavezf marcochavezf added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2024
@suneox
Copy link
Contributor

suneox commented Jul 21, 2024

Not overdue, still waiting for an internal fix

@marcochavezf
Copy link
Contributor

No update, I will move to weekly since it's vip-vsb and low

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@marcochavezf marcochavezf added Weekly KSv2 and removed Daily KSv2 labels Jul 22, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

@JmillsExpensify @marcochavezf @suneox this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@marcochavezf
Copy link
Contributor

No update, addressing other high priority items this week

@melvin-bot melvin-bot bot removed the Overdue label Jul 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2024
@marcochavezf
Copy link
Contributor

I will check it out today or tomorrow, I will move it to daily meanwhile

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@marcochavezf marcochavezf added Daily KSv2 and removed Weekly KSv2 labels Aug 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2024
Copy link

melvin-bot bot commented Aug 15, 2024

@JmillsExpensify, @marcochavezf, @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@marcochavezf
Copy link
Contributor

Sorry, no update. I've been caught up with other priorities.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 15, 2024
@suneox
Copy link
Contributor

suneox commented Aug 19, 2024

This issue will be handled by the internal team, so I’d like to self-unassign

@suneox suneox removed their assignment Aug 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@marcochavezf
Copy link
Contributor

Moving it back to weekly

@marcochavezf marcochavezf added Weekly KSv2 and removed Daily KSv2 labels Aug 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2024
@marcochavezf
Copy link
Contributor

No update, addressing other higher priority issues

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@marcochavezf
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@marcochavezf
Copy link
Contributor

Not a priority, unassigning myself for now

@marcochavezf marcochavezf removed their assignment Sep 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 17, 2024
@JmillsExpensify
Copy link

Just going to close if this isn't a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants