Add toggle for enable/disable instead of label #54451

abzokhattab · 2024-12-22T11:45:46Z

Explanation of Change

Fixed Issues

$ #53798
PROPOSAL: #53798 (comment)

Tests

Categories :

Create a workspace.
Navigate to workspace settings.
Open the Categories page.
Verify that the Status column uses a toggle switch instead of a label and confirm that the status updates correctly when toggled on or off
When offline, if a user removes a category record, ensure the toggle is disabled.

Taxes :

Create a workspace.
Navigate to workspace settings.
Open the Taxes page.
Verify that the Status column uses a toggle switch instead of a label and confirm that the status updates correctly when toggled on or off
When offline, if a user removes a tax record, ensure the toggle is disabled.

Distance Rates :

Create a workspace.
Navigate to workspace settings.
Enable Distance Rate from the More Features page.
Open the Distance Rate page.
Verify that the Status column uses a toggle switch instead of a label and confirm that the status updates correctly when toggled on or off
When offline, if a user removes a rate record, ensure the toggle is disabled.

Tags :

Create a workspace.
Navigate to workspace settings.
Open the Tags page.
Verify that the Status column uses a toggle switch instead of a label and confirm that the status updates correctly when toggled on or off
When offline, if a user removes a tag record, ensure the toggle is disabled.

Multilevel Tags :

Prerequisites:

Create a workspace with dependent tags imported from the old dot system. Use this file to add dependent tags.

Navigate to workspace settings.
Open the Tags page.
Verify that the Status column uses a toggle switch instead of a label and confirm that the status updates correctly when toggled on or off.

Report Fields :

Create a workspace.
Navigate to workspace settings.
Enable Report Fields from the More Features page.
Open the Report Fields page.
Create a report field with the type List .
Edit the report field and navigate to the List page.
Verify that the Status column uses a toggle switch instead of a label and confirm that the status updates correctly when toggled on or off.

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-12.at.00.45.35.mov

Android: mWeb Chrome

Screen.Recording.2024-12-12.at.00.51.20.mov

iOS: Native

Screen.Recording.2024-12-12.at.00.45.35.mov

iOS: mWeb Safari

Screen.Recording.2024-12-12.at.00.51.20.mov

MacOS: Chrome / Safari

Categories:

Screen.Recording.2024-12-12.at.00.52.19.mov

Taxes:

taxes.mov

Distance Rates:

distance.mov

Tags:

tags-single.mov

Multilevel Tags:

tags-mult.mov

Report Fields:

report-fields.mov

MacOS: Desktop

Screen.Recording.2024-12-10.at.00.04.15.mov

melvin-bot · 2024-12-22T11:45:51Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2024-12-30T08:27:50Z

I'll review this today.

akinwale · 2024-12-31T06:42:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

54451-web.mp4

MacOS: Desktop

akinwale · 2024-12-31T06:42:26Z

@abzokhattab Could you please fix merge conflicts? Thanks.

abzokhattab · 2024-12-31T09:35:54Z

Done! thanks for the comment...please review and let me know if you have any other comment.

akinwale · 2025-01-03T16:58:09Z

@abzokhattab Looks good. Could you please check and fix the lint error and then I can approve? Thanks.

abzokhattab · 2025-01-05T20:30:27Z

ok thanks working on them

akinwale · 2025-01-08T08:30:55Z

@abzokhattab Any update here?

…/disable-instead-of-label

akinwale

LGTM.

abzokhattab · 2025-01-09T07:27:22Z

Fixed

grgia · 2025-01-09T12:07:57Z

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

    const distanceRatesList = useMemo<RateForList[]>(
        () =>
            Object.values(customUnitRates)
                .sort((rateA, rateB) => (rateA?.rate ?? 0) - (rateB?.rate ?? 0))
                .map((value) => ({
-                    value: value.customUnitRateID ?? '',
+                    value: value.customUnitRateID ?? CONST.EMPTY_STRING,


Do we need to start enforcing this @akinwale?

No, this approach is wrong.
Please check https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-ids:

String IDs should not have a default value

This was the whole purpose of the eslint change – to correctly handle such cases.
Since this PR, apparently, caused multiple regressions, I suggest that a follow-up PR should handle these missing IDs properly.

An example PR for proper handling is #54297

@abzokhattab @akinwale yes please, lets fix this. Please read over the documentation linked and feel free to ask in slack (also search past convos in slack as this was discussed multiple times)

Thank you, I misunderstood that we can use the default value from a fixed constant. Should I raise a PR to fix the blocker issues along with this one?

@abzokhattab Please raise a single PR to fix all the issues and tag the fixed issues in the OP. I am available to review so ping me when it's ready.

grgia

Changes LGTM, comment is NAB

OSBotify · 2025-01-09T15:09:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-10T03:57:31Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-01-10T10:39:17Z

@abzokhattab PR is failing on iOS - issue #55053

https://platform.applause.com/services/links/v1/external/3545946ba580ddfef3e0c7ecefe80a4508b44aa0231a2436f33b42c36aea72dc

https://platform.applause.com/services/links/v1/external/0002064272c1989f9f2ea8dbceaa162d0c8e83f97fdda23698351dda03939cd1

github-actions · 2025-01-11T03:25:17Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-13T13:58:38Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Add toggle for enable/disable instead of label

f1ef671

abzokhattab requested a review from a team as a code owner December 22, 2024 11:45

melvin-bot bot requested a review from akinwale December 22, 2024 11:45

melvin-bot bot removed the request for review from a team December 22, 2024 11:45

main

6dd35a2

abzokhattab added 2 commits January 9, 2025 02:09

Merge remote-tracking branch 'origin/main' into add-toggle-for-enable…

771069b

…/disable-instead-of-label

fixing eslint errs

a5d13c8

akinwale approved these changes Jan 9, 2025

View reviewed changes

melvin-bot bot requested a review from grgia January 9, 2025 05:53

grgia reviewed Jan 9, 2025

View reviewed changes

grgia approved these changes Jan 9, 2025

View reviewed changes

grgia merged commit c9a90e0 into Expensify:main Jan 9, 2025
18 checks passed

github-actions bot mentioned this pull request Jan 10, 2025

Deploy Checklist: New Expensify 2025-01-10 #55051

Closed

54 tasks

Gonals mentioned this pull request Jan 10, 2025

[Due for payment 2025-02-10] [$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates #55052

Closed

8 tasks

mountiny mentioned this pull request Jan 10, 2025

Tags - Main tag always reverts to "on" state when trying to toggle it off #55053

Closed

8 tasks

thienlnam mentioned this pull request Jan 10, 2025

[CP Staging] Revert "Add toggle for enable/disable instead of label" + Remove usages of EMPTY_STRING #55101

Merged

48 tasks

melvin-bot bot mentioned this pull request Jan 11, 2025

[Due for payment 2025-02-10] [$250] Add toggle for enable/disable to each category row in Categories page of workspace settings #53798

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add toggle for enable/disable instead of label #54451

Add toggle for enable/disable instead of label #54451

abzokhattab commented Dec 22, 2024 •

edited

Loading

melvin-bot bot commented Dec 22, 2024

akinwale commented Dec 30, 2024

akinwale commented Dec 31, 2024 •

edited

Loading

akinwale commented Dec 31, 2024

abzokhattab commented Dec 31, 2024

akinwale commented Jan 3, 2025

abzokhattab commented Jan 5, 2025

akinwale commented Jan 8, 2025

akinwale left a comment

abzokhattab commented Jan 9, 2025

grgia Jan 9, 2025

paultsimura Jan 10, 2025

mountiny Jan 10, 2025

abzokhattab Jan 10, 2025

akinwale Jan 10, 2025

grgia left a comment

OSBotify commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

izarutskaya commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

github-actions bot commented Jan 13, 2025

Add toggle for enable/disable instead of label #54451

Add toggle for enable/disable instead of label #54451

Conversation

abzokhattab commented Dec 22, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 22, 2024

akinwale commented Dec 30, 2024

akinwale commented Dec 31, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

akinwale commented Dec 31, 2024

abzokhattab commented Dec 31, 2024

akinwale commented Jan 3, 2025

abzokhattab commented Jan 5, 2025

akinwale commented Jan 8, 2025

akinwale left a comment

Choose a reason for hiding this comment

abzokhattab commented Jan 9, 2025

grgia Jan 9, 2025

Choose a reason for hiding this comment

paultsimura Jan 10, 2025

Choose a reason for hiding this comment

mountiny Jan 10, 2025

Choose a reason for hiding this comment

abzokhattab Jan 10, 2025

Choose a reason for hiding this comment

akinwale Jan 10, 2025

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

izarutskaya commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

github-actions bot commented Jan 13, 2025

abzokhattab commented Dec 22, 2024 •

edited

Loading

akinwale commented Dec 31, 2024 •

edited

Loading