[Due for payment 2025-02-10] [$250] Distance rates - Dropdown does not show "Enable" after disabling rate while selecting all rates

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.83-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Distance rates.
3. Add one more distance rate if there is only one rate.
4. Select all rates via checkbox.
5. Click on the toggle on one of the rates to disable it.
6. Click on the dropdown button on the top right.

Expected Result:

The dropdown menu will show "Enable" option because now there is a disabled rate (it works this way with categories).

Actual Result:

The dropdown menu does not show "Enable" option after disabling a rate while selecting all rates.
It only appears after reselecting the rates.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6710576_1736485086531.20250110_123206.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877738099993152916
• Upwork Job ID: 1877738099993152916
• Last Price Increase: 2025-01-10

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2025-01-10 08:28:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The dropdown menu does not show "Enable" option after disabling a rate while selecting all rates.
It only appears after reselecting the rates.

What is the root cause of that problem?

We are not updating selectedDistanceRates when update distance rate status

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 101 to 118 in 219e66d

	const updateDistanceRateEnabled = useCallback(
	(value: boolean, rateID: string) => {
	if (!customUnit) {
	return;
	}
	const rate = customUnit?.rates?.[rateID];
	// Rates can be disabled or deleted as long as in the remaining rates there is always at least one enabled rate and there are no pending delete action
	const canDisableOrDeleteRate = Object.values(customUnit?.rates ?? {}).some(
	(distanceRate: Rate) => distanceRate?.enabled && rateID !== distanceRate?.customUnitRateID && distanceRate?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	);
	if (!rate?.enabled || canDisableOrDeleteRate) {
	DistanceRate.setPolicyDistanceRatesEnabled(policyID, customUnit, [{...rate, enabled: value}]);
	} else {
	setIsWarningModalVisible(true);
	}
	},
	[customUnit, policyID],

What changes do you think we should make in order to solve the problem?

We can rely on rateID and value in the function updateDistanceRateEnabled to update selectedDistanceRates

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Gonals]

#54451 Should have fixed this. Closing

[mountiny]

@Gonals I am not sure if I understand your comment - this was reported on staging and the PR you have linked was deployed to staging now. So it probably did not fix it? Let me know what I am missing and feel free to remove the label and close the issue again

[Gonals]

@Gonals I am not sure if I understand your comment - this was reported on staging and the PR you have linked was deployed to staging now. So it probably did not fix it? Let me know what I am missing and feel free to remove the label and close the issue again

Ah, I think you are right and I misunderstood the purpose of the PR. Looking into this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877738099993152916

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[Gonals]

@thienlnam, @mountiny, I don't think we need to block deploy on this. It is a new feature (you couldn't really do this flow before the switch) and not very intrusive. That said, it is Friday, so we have until Monday to fix this.

@abzokhattab, @abekkala, this was caused by #54451

[thienlnam]

Looks like I'll be able to deploy today, going to revert it since it is linked to another blocker as well

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add toggle for enable/disable instead of label #55192

If no regressions arise, payment will be issued on 2025-02-10. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment (Needs manual offer from BZ)

[melvin-bot]

@paultsimura @abekkala @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]