Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] feat: Step 3 UI #51667

Merged
merged 30 commits into from
Nov 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
bd49f5c
feat: step 3
MrMuzyk Oct 28, 2024
321b51b
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Oct 28, 2024
22d5afd
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Oct 29, 2024
0467eb2
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Oct 29, 2024
d66962c
feat: step 3 pt 2
MrMuzyk Oct 29, 2024
a7dca3c
feat: remove mocked provinces and add comment to remaining mock
MrMuzyk Oct 29, 2024
7e86dc5
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Oct 29, 2024
d97c3f3
fix: prettier
MrMuzyk Oct 29, 2024
6d1a23f
fix: linter, ts
MrMuzyk Oct 29, 2024
5438548
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Oct 30, 2024
618b560
fix: simplify PushRowWithModal
MrMuzyk Oct 30, 2024
9cd5c5e
fix: polishing fixes
MrMuzyk Oct 31, 2024
a50dac3
fix: validation fixes
MrMuzyk Oct 31, 2024
4a2e40f
fix: replace substring
MrMuzyk Oct 31, 2024
7bc7df5
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Oct 31, 2024
e077889
fix: AddressBusiness
MrMuzyk Oct 31, 2024
3ae86bc
fix: change resetting so autocomplete works
MrMuzyk Oct 31, 2024
bc4e6d0
fix: move lists outside of component
MrMuzyk Oct 31, 2024
789f0af
fix: cr fixes and translations
MrMuzyk Nov 4, 2024
c38f54e
fix: typings
MrMuzyk Nov 4, 2024
3c1509b
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Nov 4, 2024
f0fe0b2
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Nov 5, 2024
9fcafe6
fix: fix crash
MrMuzyk Nov 5, 2024
b20e4e0
fix: minor correction
MrMuzyk Nov 5, 2024
8e089e2
fix: Improve phone number validation
MrMuzyk Nov 5, 2024
a0e96f1
fix: fix state displaying and validation
MrMuzyk Nov 5, 2024
f9c2db5
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Nov 5, 2024
bff7aaf
fix: reset state errors whenever stepField change
MrMuzyk Nov 6, 2024
370b0b3
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk Nov 6, 2024
ce274cb
fix: tighten phone number validation
MrMuzyk Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:Expensify/App into feat/step-3-ui
MrMuzyk committed Nov 6, 2024

Verified

This commit was signed with the committer’s verified signature.
commit 370b0b3b4070fecaec027aaafcd0f04331617a81
11 changes: 8 additions & 3 deletions src/libs/ValidationUtils.ts
Original file line number Diff line number Diff line change
@@ -20,9 +20,14 @@ import StringUtils from './StringUtils';
*/
function validateCardNumber(value: string): boolean {
let sum = 0;
for (let i = 0; i < value.length; i++) {
let intVal = parseInt(value.slice(i, i + 1), 10);
if (i % 2 === 0) {
let shouldDouble = false;

// Loop through the card number from right to left
for (let i = value.length - 1; i >= 0; i--) {
let intVal = parseInt(value[i], 10);

// Double every second digit from the right
if (shouldDouble) {
intVal *= 2;
if (intVal > 9) {
intVal -= 9;
You are viewing a condensed version of this merge commit. You can view the full changes here.