-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QBD] [Export] Export company cards page #50677
Merged
lakchote
merged 14 commits into
Expensify:main
from
ZhenjaHorbach:qbd-export-QuickbooksDesktopCompanyCardExpenseAccountSelect
Oct 18, 2024
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
15ccf45
create draft commit and add CompanyCardExpenseAccount screens
ZhenjaHorbach b45e4ef
add CardExpenseAccountSelectPage
ZhenjaHorbach 1008963
add QuickbooksDesktopNonReimbursableDefaultVendor screen
ZhenjaHorbach 99dc908
refactor code
ZhenjaHorbach 7c20b06
add type for write command
ZhenjaHorbach 5ee6eef
update translates
ZhenjaHorbach 129bc2f
remove unnecessary translations
ZhenjaHorbach c30699a
fix conflicts
ZhenjaHorbach 7708b9d
update non-reimbursable values
ZhenjaHorbach ed82b19
fix conflicts
ZhenjaHorbach fcd3e86
add safe operators for screens
ZhenjaHorbach 447ac39
fix conflicts
ZhenjaHorbach fa57318
fix conflicts
ZhenjaHorbach 8cf9bf0
update pendingActions
ZhenjaHorbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/libs/API/parameters/UpdateQuickbooksDesktopCompanyCardExpenseAccountTypeParams.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import type {QBDNonReimbursableExportAccountType} from '@src/types/onyx/Policy'; | ||
|
||
type UpdateQuickbooksDesktopCompanyCardExpenseAccountTypeParams = { | ||
policyID: string; | ||
nonReimbursableExpensesExportDestination: QBDNonReimbursableExportAccountType; | ||
nonReimbursableExpensesAccount: string; | ||
nonReimbursableBillDefaultVendor: string; | ||
idempotencyKey: string; | ||
}; | ||
|
||
export default UpdateQuickbooksDesktopCompanyCardExpenseAccountTypeParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the same texts for Reimbursable CHECK and Non-Reimbursable CHECK on OldDot
I made the same on NewDot
So I used texts from Reimbursable CHECK
And all other translations are taken from QBO