[QBD] [Export] Export company cards page #50677

ZhenjaHorbach · 2024-10-11T21:17:20Z

Details

Fixed Issues

$ #49712
PROPOSAL:

Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Export" menu under QuickBooks Desktop connection
Click on Export company card expenses as
Open Export as
Verify that there is a list of export types and after selecting one of them, it becomes the current
Open list of accounts
Verify that the list of accounts matches the Export as type and after selecting one of them, it becomes the current
On Export as select Vendor bill
Verify that after selecting Vendor bill, Default vendor toggle is displayed on the screen and when toggle is on, list of vendors is also displayed
Open list of vendors
Verify that there is a list of vendors and after selecting one of them, it becomes the current

Verify that no errors appear in the JS console

Offline tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Export" menu under QuickBooks Desktop connection
Click on Export company card expenses as
Open Export as
Verify that there is a list of export types and after selecting one of them, it becomes the current
Open list of accounts
Verify that the list of accounts matches the Export as type and after selecting one of them, it becomes the current
On Export as select Vendor bill
Verify that after selecting Vendor bill, Default vendor toggle is displayed on the screen and when toggle is on, list of vendors is also displayed
Open list of vendors
Verify that there is a list of vendors and after selecting one of them, it becomes the current

QA Steps

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Export" menu under QuickBooks Desktop connection
Click on Export company card expenses as
Open Export as
Verify that there is a list of export types and after selecting one of them, it becomes the current
Open list of accounts
Verify that the list of accounts matches the Export as type and after selecting one of them, it becomes the current
On Export as select Vendor bill
Verify that after selecting Vendor bill, Default vendor toggle is displayed on the screen and when toggle is on, list of vendors is also displayed
Open list of vendors
Verify that there is a list of vendors and after selecting one of them, it becomes the current

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ZhenjaHorbach · 2024-10-15T09:17:17Z

src/languages/es.ts

@@ -2444,6 +2444,8 @@ const translations = {
                [CONST.QUICKBOOKS_DESKTOP_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY]: 'Asiento contable',
                [CONST.QUICKBOOKS_DESKTOP_REIMBURSABLE_ACCOUNT_TYPE.CHECK]: 'Cheque',

+                [`${CONST.QUICKBOOKS_DESKTOP_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.CHECK}Description`]:
+                    'Crearemos un cheque desglosado para cada informe de Expensify y lo enviaremos desde la cuenta bancaria a continuación.',


Since we have the same texts for Reimbursable CHECK and Non-Reimbursable CHECK on OldDot

I made the same on NewDot
So I used texts from Reimbursable CHECK

And all other translations are taken from QBO

melvin-bot · 2024-10-15T10:34:15Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-10-15T11:10:45Z

@hoangzinh
@lakchote

PR is ready !

hoangzinh · 2024-10-15T15:09:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-17.at.23.37.12.android.mov

Android: mWeb Chrome

Screen.Recording.2024-10-17.at.23.34.04.android.chrome.mov

iOS: Native

Screen.Recording.2024-10-17.at.23.39.13.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-10-17.at.23.32.27.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-17.at.23.28.32.web.mov

MacOS: Desktop

Screen.Recording.2024-10-17.at.23.31.26.desktop.mov

hoangzinh · 2024-10-15T16:43:31Z

I know that we copied most of logic from QBO, but this offline behavior is weird to me.

When I updated "Export as" offline, most of the menus were greyed out, except the "Default vendor" toggle button (even the "Default vendor" select page is also greyed out)
When I updated "Default vendor" toggle button, the "Default vendor" select page was not greyed out, although it's just displayed when "Default vendor" toggle is on.

What do you guys think?

Screen.Recording.2024-10-15.at.23.38.55.mov

ZhenjaHorbach · 2024-10-15T16:46:23Z

I know that we copied most of logic from QBO, but this offline behavior is weird to me.

When I updated "Export as" offline, most of the menus were greyed out, except the "Default vendor" toggle button (even the "Default vendor" select page is also greyed out)

When I updated "Default vendor" toggle button, the "Default vendor" select page was not greyed out, although it's just displayed when "Default vendor" toggle is on.

What do you guys think?

Screen.Recording.2024-10-15.at.23.38.55.mov

Agree
It's weird
But I think it's better to create a separate issue for QBO and for QBD

Since different behavior on very similar screens is also not the best practice

But I don't mind fixing it now

lakchote · 2024-10-16T06:07:10Z

I know that we copied most of logic from QBO, but this offline behavior is weird to me.

When I updated "Export as" offline, most of the menus were greyed out, except the "Default vendor" toggle button (even the "Default vendor" select page is also greyed out)

When I updated "Default vendor" toggle button, the "Default vendor" select page was not greyed out, although it's just displayed when "Default vendor" toggle is on.

What do you guys think?

Screen.Recording.2024-10-15.at.23.38.55.mov

Tagging @Expensify/design for their input.

shawnborton · 2024-10-16T07:40:07Z

Hmm I'm not too sure tbh, let's see what @trjExpensify thinks.

trjExpensify · 2024-10-16T18:41:58Z

Hm, yeah, is it because you had vendor bills configured with default vendor toggled on before going offline, so that was the current state of the setting?

Does look weird though, I agree. It would be better to reduce the opacity of it like the other fields that are dependent on the Export as method chosen.

ZhenjaHorbach · 2024-10-17T06:54:39Z

Hm, yeah, is it because you had vendor bills configured with default vendor toggled on before going offline, so that was the current state of the setting?

Does look weird though, I agree. It would be better to reduce the opacity of it like the other fields that are dependent on the Export as method chosen.

Thanks for the clarification!

ZhenjaHorbach · 2024-10-17T06:55:26Z

@hoangzinh
I updated pending actions !

OSBotify · 2024-10-18T08:09:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-18T19:04:51Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.51-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-22T04:38:07Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

github-actions · 2024-10-22T17:20:31Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ZhenjaHorbach added 11 commits October 11, 2024 23:16

create draft commit and add CompanyCardExpenseAccount screens

15ccf45

add CardExpenseAccountSelectPage

b45e4ef

add QuickbooksDesktopNonReimbursableDefaultVendor screen

1008963

refactor code

99dc908

add type for write command

7c20b06

update translates

5ee6eef

remove unnecessary translations

129bc2f

fix conflicts

c30699a

update non-reimbursable values

7708b9d

fix conflicts

ed82b19

add safe operators for screens

fcd3e86

ZhenjaHorbach commented Oct 15, 2024

View reviewed changes

ZhenjaHorbach marked this pull request as ready for review October 15, 2024 10:34

ZhenjaHorbach requested a review from a team as a code owner October 15, 2024 10:34

melvin-bot bot requested review from hoangzinh and removed request for a team October 15, 2024 10:34

fix conflicts

447ac39

lakchote self-requested a review October 15, 2024 14:37

fix conflicts

fa57318

update pendingActions

8cf9bf0

hoangzinh approved these changes Oct 17, 2024

View reviewed changes

lakchote approved these changes Oct 18, 2024

View reviewed changes

lakchote merged commit d1f6190 into Expensify:main Oct 18, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 18, 2024

Deploy Checklist: New Expensify 2024-10-18 #51106

Closed

59 tasks

melvin-bot bot mentioned this pull request Oct 22, 2024

[$250] [HOLD for payment 2024-10-29] [Wave Control] [QBD] [Export] Export company cards page #49712

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QBD] [Export] Export company cards page #50677

[QBD] [Export] Export company cards page #50677

ZhenjaHorbach commented Oct 11, 2024 •

edited

Loading

ZhenjaHorbach Oct 15, 2024 •

edited

Loading

melvin-bot bot commented Oct 15, 2024

ZhenjaHorbach commented Oct 15, 2024

hoangzinh commented Oct 15, 2024 •

edited

Loading

hoangzinh commented Oct 15, 2024

ZhenjaHorbach commented Oct 15, 2024 •

edited

Loading

lakchote commented Oct 16, 2024

shawnborton commented Oct 16, 2024

trjExpensify commented Oct 16, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 17, 2024

ZhenjaHorbach commented Oct 17, 2024

OSBotify commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

[QBD] [Export] Export company cards page #50677

[QBD] [Export] Export company cards page #50677

Conversation

ZhenjaHorbach commented Oct 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ZhenjaHorbach Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Oct 15, 2024

ZhenjaHorbach commented Oct 15, 2024

hoangzinh commented Oct 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Oct 15, 2024

ZhenjaHorbach commented Oct 15, 2024 • edited Loading

lakchote commented Oct 16, 2024

shawnborton commented Oct 16, 2024

trjExpensify commented Oct 16, 2024 • edited Loading

ZhenjaHorbach commented Oct 17, 2024

ZhenjaHorbach commented Oct 17, 2024

OSBotify commented Oct 18, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024

ZhenjaHorbach commented Oct 11, 2024 •

edited

Loading

ZhenjaHorbach Oct 15, 2024 •

edited

Loading

hoangzinh commented Oct 15, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 15, 2024 •

edited

Loading

trjExpensify commented Oct 16, 2024 •

edited

Loading