Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display sync error when connecting to NetSuite with invalid credentials #47059

Merged
merged 3 commits into from
Aug 19, 2024
+4 −1
Merged

Display sync error when connecting to NetSuite with invalid credentials #47059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c07f94c
Display sync error when connecting to NetSuite with invalid credentials
nyomanjyotisa Aug 8, 2024
ef48395
minor update
nyomanjyotisa Aug 19, 2024
716bd7c
Merge branch 'main' into issue-46768
nyomanjyotisa Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libs/actions/connections/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,10 @@ function getSynchronizationErrorMessage(policy: OnyxEntry<Policy>, connectionNam
const syncError = Localize.translateLocal('workspace.accounting.syncError', connectionName);
// NetSuite does not use the conventional lastSync object, so we need to check for lastErrorSyncDate
if (connectionName === CONST.POLICY.CONNECTIONS.NAME.NETSUITE) {
if (!isSyncInProgress && !!policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE].lastErrorSyncDate) {
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing "Can't connect to NetSuite" message to appear after connecting to Netsuite, we fixed this in #50032.

!isSyncInProgress &&
(!!policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE].lastErrorSyncDate || policy?.connections?.[CONST.POLICY.CONNECTIONS.NAME.NETSUITE]?.verified === false)
) {
return syncError;
}
return;
Expand Down
Loading