-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error shows briefly while connecting NetSuite #50032
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Native01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: Native03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4MacOS: Desktop06_MacOS_Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Netsuite policy.connections object contains and returns the correct values for lastSync
and lastSync.isSuccesful
and also lastSync.errorDate
just fine, which means this line should be sufficient to deal with the Netsuite synchronisation error messages.
It also doesn’t cause #46768 to reoccur.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Performance regression was introduced here: We are currently fine with that regression, as it will be fixed later on. The e2e system reports regressions for every new PR until a new release version has been created (this will be improved soon). So can be ignored! |
🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.45-1 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.45-4 🚀
|
Details
While connecting with NetSuite, we saw an error briefly, this PR fixes that.
Fixed Issues
$ #49752
PROPOSAL: #49752 (comment)
Tests
Accounting
feature.Accounting
, clickNetSuite
.Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-10-02.at.14.12.09.mov
Android: mWeb Chrome
Screen.Recording.2024-10-02.at.14.04.30.mov
iOS: Native
Screen.Recording.2024-10-02.at.13.57.45.mov
iOS: mWeb Safari
Screen.Recording.2024-10-02.at.14.01.45.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-02.at.13.25.10.mov
MacOS: Desktop
Screen.Recording.2024-10-02.at.13.30.17.mov