Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PromotedActionsBar #41972
feat: add PromotedActionsBar #41972
Changes from 15 commits
8521e75
4b80097
2280259
abb830c
27bb412
9cf7497
08e44fc
7b3b2f9
b0c18e5
8ced990
902b774
3a4e6f4
5489810
bc6004e
dfdb1f5
738075d
324080b
8fe01f8
22ed96d
3fafaff
b8a6221
1e67021
5a86528
8771bd6
5971fb3
0f5aa5d
6d1e40e
f2d0e2f
cc302ff
0367b26
8431492
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to use
PromotedAction
typesjoin
,share
, andhold
in this PR? If not, let us keep this code commented and add relevant comments as to where this will be used. This can be uncommented later when this is used. This will also keep this PR neat.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've commented this out. However, adding all those actions here, in one place, might be a good idea, as later on, a few PRs might need in simultaneously, leading to conflicts and duplicated work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a WIP PR for this yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cdOut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m handling this one in my ReportDetailsPage PR, I’ll link it here after I put up a draft PR for it later in the evening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this PR we're already moving it there.