Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PromotedActionsBar #41972

Merged
merged 31 commits into from
May 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
8521e75
refactor: update ChatDetailsQuickActionsBar to be generic
kosmydel May 10, 2024
4b80097
x
kosmydel May 10, 2024
2280259
Add useQuickActions hook
kosmydel May 13, 2024
abb830c
share type with ThreeDotsMenuItem
kosmydel May 13, 2024
27bb412
Merge branch 'main' into @kosmydel/details-revamp/actions-bar
kosmydel May 13, 2024
9cf7497
refactor: rename ChatDetailsQuickActionsBar to PromotedActionsBar
kosmydel May 13, 2024
08e44fc
cleanup
kosmydel May 14, 2024
7b3b2f9
feat: add CommentBubbles icon
kosmydel May 14, 2024
b0c18e5
fix: stopwatch icon color
kosmydel May 14, 2024
8ced990
fix: actions config
kosmydel May 14, 2024
902b774
fix: key
kosmydel May 14, 2024
3a4e6f4
Merge branch 'main' into @kosmydel/details-revamp/actions-bar
kosmydel May 14, 2024
5489810
fix: add medium prop
kosmydel May 14, 2024
bc6004e
fix: update icons
kosmydel May 14, 2024
dfdb1f5
fix: remove button container padding
kosmydel May 14, 2024
738075d
fix: change gap to 8px
kosmydel May 14, 2024
324080b
address review
kosmydel May 15, 2024
8fe01f8
adress review
kosmydel May 15, 2024
22ed96d
feat: add storybook
kosmydel May 15, 2024
3fafaff
fix: typo
kosmydel May 15, 2024
b8a6221
Merge branch 'main' into @kosmydel/details-revamp/actions-bar
kosmydel May 15, 2024
1e67021
fix: make the report optional
kosmydel May 15, 2024
5a86528
feat: add better styles
kosmydel May 15, 2024
8771bd6
refactor: support separate parameters for each predefined action
kosmydel May 15, 2024
5971fb3
refactor: change order of the buttons
kosmydel May 15, 2024
0f5aa5d
refactor: ReportDetailsPage
kosmydel May 15, 2024
6d1e40e
Revert "refactor: ReportDetailsPage"
kosmydel May 15, 2024
f2d0e2f
fix: do not display empty PromotedActionsBar
kosmydel May 20, 2024
cc302ff
feat: max promoted action width
kosmydel May 21, 2024
0367b26
Merge branch 'Expensify:main' into @kosmydel/actions-bar
kosmydel May 29, 2024
8431492
cleanup: remove TODO
kosmydel May 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: key
  • Loading branch information
kosmydel committed May 14, 2024
commit 902b774338c30a2081d09e444cc003bebdd593de
6 changes: 4 additions & 2 deletions src/components/PromotedActionsBar.tsx
Original file line number Diff line number Diff line change
@@ -112,9 +112,11 @@ function PromotedActionsBar({report, promotedActions, shouldShowLeaveButton}: Pr
</View>
)}
{promotedActions.map(({key, onSelected, ...props}) => (
<View style={[styles.flex1]}>
<View
style={[styles.flex1]}
key={key}
>
<Button
key={key}
onPress={onSelected}
iconFill={theme.icon}
// eslint-disable-next-line react/jsx-props-no-spreading
Loading