[Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #41641

hungvu193 · 2024-05-04T16:15:27Z

Details

Create the Preferred exporter select page

Fixed Issues

$ #39742
PROPOSAL: N/A

Tests

Precondition: User connected to Xero

Go to Workspace => Accounting
Choose Export => Preferred Exporter, click on the MenuItem
Try to update the preferred exporter email few times.
Verify that it's updated correctly.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-06.at.17.16.02.mov

Android: mWeb Chrome

Screen.Recording.2024-05-06.at.17.23.48.mov

iOS: Native

Screen.Recording.2024-05-06.at.17.07.24.mov

iOS: mWeb Safari

Screen.Recording.2024-05-06.at.17.08.33.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-06.at.16.20.54.mov

MacOS: Desktop

Screen.Recording.2024-05-06.at.16.21.31.mov

hungvu193 · 2024-05-04T16:18:01Z

Hold for #41554

mananjadhav · 2024-05-04T18:09:08Z

This should be blocked for Invoice Account Selector PR as well right? I can see changes that I just reviewed.

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx

src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx

hungvu193 · 2024-05-05T05:33:15Z

This PR is not ready yet. Please wait until I mark it as ready 😄

mananjadhav · 2024-05-05T06:10:51Z

Ohh 😄. I stumbled upon this one.

hungvu193 · 2024-05-06T09:22:22Z

Hold for #41554

Still being held but almost ready!

melvin-bot · 2024-05-06T09:22:30Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/languages/en.ts

src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx

mananjadhav

Small refactor comments, but I think we should test this once Export page is merged.

…er-select-page

mananjadhav · 2024-05-07T18:52:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Revised
https://github.com/Expensify/App/assets/3069065/26bc3dff-6e2a-4a7e-b301-d92bf138d6f0

Old
https://github.com/Expensify/App/assets/3069065/a60afa0c-224a-4a6e-a42c-9444e10d304d

Android: mWeb Chrome

Revised

mweb-xero-preferred-exporter.mov

Old
https://github.com/Expensify/App/assets/3069065/8dbf6cc0-1d5b-41a8-a9ee-cda714ede6af

iOS: Native

Revised

ios-xero-preferred-exporter.mov

Old
https://github.com/Expensify/App/assets/3069065/65c1312c-ba9c-480c-8d52-21d63e1b7c39

iOS: mWeb Safari

Revised
https://github.com/Expensify/App/assets/3069065/fb1b1a64-469d-4d92-b55c-9486598585d0

Old
https://github.com/Expensify/App/assets/3069065/459fac12-edce-44c3-9c27-6fa0a9eb8811

MacOS: Chrome / Safari

Revised

web-xero-preferred-exporter.mov

Old
https://github.com/Expensify/App/assets/3069065/4494b3a0-f146-402a-bd50-e60cca4ef0d5

MacOS: Desktop

Revised

desktop-xero-preferred-exporter.mov

Old
https://github.com/Expensify/App/assets/3069065/b2e8e97b-ed94-497c-a4f8-4882bec3e61e

melvin-bot · 2024-05-07T18:55:53Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #39742 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mananjadhav · 2024-05-07T21:07:19Z

Tagging @Expensify/design. I wanted to also confirm if it's the only email in the list do we need to navigate twice?

dannymcclain · 2024-05-07T21:42:36Z

Thanks for bringing this up—no, we do not want to do the double-navigate thing you're showing. The second screen should more closely follow what we do for language select (for example). That would give us something like this:

Where we have the push input on the first screen, and then the immediate screen after that is the list with the explainer text.

mananjadhav · 2024-05-07T21:50:52Z

src/pages/workspace/accounting/xero/export/XeroExportConfigurationPage.tsx

@@ -22,7 +24,9 @@ function XeroExportConfigurationPage({policy}: WithPolicyConnectionsProps) {
    const menuItems: MenuItem[] = [
        {
            description: translate('workspace.xero.preferredExporter'),
-            onPress: () => {},
+            onPress: () => {


@hungvu193 @lakchote I am not sure how we're handling the pendingFields here. I can see it's tagged as policy.pendingFields.xeroConfigPreferredExporter in the document but I don't see it being used. Neither here nor in @lakchote's PR for Bill selector.

Yeah, I didn't find any usage of it.

Yes, it shouldn't be xeroConfigPreferredExporter or anything like that. I previously wrote that before the implementation and I was wrong.

The correct way to do this is would be here to use pendingFields?.export for the pending action.

trjExpensify · 2024-05-07T23:24:18Z

Thanks for bringing this up—no, we do not want to do the double-navigate thing you're showing. The second screen should more closely follow what we do for language select (for example). That would give us something like this:

Where we have the push input on the first screen, and then the immediate screen after that is the list with the explainer text.

Huge +1.

dubielzyk-expensify · 2024-05-07T23:46:14Z

Exactly. Thanks for clarifying, @dannymcclain . I assume this is reflected in the Figma file? If not, let's update it

hungvu193 · 2024-05-08T01:50:30Z

I did it like the docs: https://docs.google.com/document/d/1VEIzxwNzedLNestAFVT5InGvD4N6FHb0922xjMGOkko/edit#heading=h.fbu7ml85rrhl
Can we update the docs?

shawnborton · 2024-05-08T01:59:19Z

Big agree with where you landed Danny.

hungvu193 · 2024-05-08T02:04:03Z

Cool. Let's me update it then.

…er-select-page

hungvu193 · 2024-05-08T03:04:12Z

Updated!

Screen.Recording.2024-05-08.at.10.00.43.mov

lakchote · 2024-05-08T04:12:00Z

cc @Expensify/design does that look good to you too now?

dubielzyk-expensify · 2024-05-08T05:44:47Z

That looks right to me!

mananjadhav · 2024-05-08T06:29:45Z

@lakchote @hungvu193 I've raised another question related to pendingFields.

mananjadhav

Reviewed again and uploaded revised screenshots in the checklist.

hungvu193 · 2024-05-09T02:02:42Z

@lakchote This will be ready for your final review 👀

lakchote · 2024-05-09T07:20:46Z

@lakchote This will be ready for your final review 👀

Approved, conflicts to be solved and then I'll merge it @hungvu193 👍

hungvu193 · 2024-05-09T07:33:17Z

Cool! I've resolved the conflicts

hungvu193 · 2024-05-09T07:53:50Z

I've fixed the lint as well, this will be ready to merge 😄

OSBotify · 2024-05-15T10:13:56Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-22T23:58:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hungvu193 added 2 commits May 4, 2024 15:35

merge with rus

62e5472

xero preferred export select page

cbecce7

mananjadhav reviewed May 4, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed May 4, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed May 4, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed May 4, 2024

View reviewed changes

src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx Outdated Show resolved Hide resolved

hungvu193 added 2 commits May 6, 2024 16:09

add PreferredExportedConfiguration screen

4c1546b

update pendingFields

e53f3e2

hungvu193 marked this pull request as ready for review May 6, 2024 09:22

hungvu193 requested a review from a team as a code owner May 6, 2024 09:22

melvin-bot bot requested review from mananjadhav and removed request for a team May 6, 2024 09:22

mananjadhav reviewed May 6, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

mananjadhav reviewed May 6, 2024

View reviewed changes

src/pages/workspace/accounting/xero/export/XeroPreferredExporterSelectPage.tsx Show resolved Hide resolved

mananjadhav reviewed May 6, 2024

View reviewed changes

hungvu193 added 3 commits May 7, 2024 10:26

update translation

b32fd3d

sync with latest parent branch

09ead33

Merge remote-tracking branch 'origin/main' into feat/preferred-export…

3e4d740

…er-select-page

hungvu193 requested a review from mananjadhav May 7, 2024 07:46

mananjadhav approved these changes May 7, 2024

View reviewed changes

lakchote self-requested a review May 7, 2024 21:12

mananjadhav reviewed May 7, 2024

View reviewed changes

hungvu193 added 2 commits May 8, 2024 09:27

Merge remote-tracking branch 'origin/main' into feat/preferred-export…

fe34369

…er-select-page

remove unused code

f992572

hungvu193 changed the base branch from main to xero-merge-freeze May 8, 2024 09:55

resolve conflict

ccda26a

mananjadhav approved these changes May 8, 2024

View reviewed changes

lakchote approved these changes May 9, 2024

View reviewed changes

resolve conflicts

2fbf7c7

update prettier

1822e23

lakchote merged commit fe73203 into Expensify:xero-merge-freeze May 9, 2024
14 checks passed

github-actions bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

m-natarajan mentioned this pull request May 15, 2024

[HOLD for payment 2024-06-11] [$250] Web - Accounting - Xero - Console error shows up when opening Preferred exporter #42195

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #41641

[Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #41641

hungvu193 commented May 4, 2024 •

edited

Loading

hungvu193 commented May 4, 2024

mananjadhav commented May 4, 2024

hungvu193 commented May 5, 2024

mananjadhav commented May 5, 2024

hungvu193 commented May 6, 2024 •

edited

Loading

melvin-bot bot commented May 6, 2024

mananjadhav left a comment

mananjadhav commented May 7, 2024 •

edited

Loading

melvin-bot bot commented May 7, 2024

mananjadhav commented May 7, 2024

dannymcclain commented May 7, 2024

mananjadhav May 7, 2024

hungvu193 May 8, 2024

lakchote May 8, 2024

trjExpensify commented May 7, 2024

dubielzyk-expensify commented May 7, 2024

hungvu193 commented May 8, 2024

shawnborton commented May 8, 2024

hungvu193 commented May 8, 2024

hungvu193 commented May 8, 2024

lakchote commented May 8, 2024

dubielzyk-expensify commented May 8, 2024

mananjadhav commented May 8, 2024

mananjadhav left a comment

hungvu193 commented May 9, 2024

lakchote commented May 9, 2024

hungvu193 commented May 9, 2024

hungvu193 commented May 9, 2024

OSBotify commented May 15, 2024

OSBotify commented May 22, 2024

[Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #41641

[Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #41641

Conversation

hungvu193 commented May 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hungvu193 commented May 4, 2024

mananjadhav commented May 4, 2024

hungvu193 commented May 5, 2024

mananjadhav commented May 5, 2024

hungvu193 commented May 6, 2024 • edited Loading

melvin-bot bot commented May 6, 2024

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented May 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented May 7, 2024

mananjadhav commented May 7, 2024

dannymcclain commented May 7, 2024

mananjadhav May 7, 2024

Choose a reason for hiding this comment

hungvu193 May 8, 2024

Choose a reason for hiding this comment

lakchote May 8, 2024

Choose a reason for hiding this comment

trjExpensify commented May 7, 2024

dubielzyk-expensify commented May 7, 2024

hungvu193 commented May 8, 2024

shawnborton commented May 8, 2024

hungvu193 commented May 8, 2024

hungvu193 commented May 8, 2024

lakchote commented May 8, 2024

dubielzyk-expensify commented May 8, 2024

mananjadhav commented May 8, 2024

mananjadhav left a comment

Choose a reason for hiding this comment

hungvu193 commented May 9, 2024

lakchote commented May 9, 2024

hungvu193 commented May 9, 2024

hungvu193 commented May 9, 2024

OSBotify commented May 15, 2024

OSBotify commented May 22, 2024

hungvu193 commented May 4, 2024 •

edited

Loading

hungvu193 commented May 6, 2024 •

edited

Loading

mananjadhav commented May 7, 2024 •

edited

Loading