-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-30] [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #39742
Comments
Triggered auto assignment to @stephanieelliott ( |
@lakchote can this be done externally or do we need to pull in an internal engineer for this? |
This will be worked on by SWM engineers, see Slack discussion here. I've removed the Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet. |
Cool, thanks for clarifying! In that case I'm gonna put this on hold for #39725 |
Still held on #39725 |
Double-checking with internal engineers, some might be interested to work on this. |
Triggered auto assignment to @JmillsExpensify ( |
Reapplying the |
Yes, we were on hold for #39725 to be merged. It was merged yesterday. Technically we are able to work on this now. I'm going to focus today on fixing the remaining bugs for the Xero authorization flow before working on it. |
I'm back from OOO, thanks for watching this while I was out @JmillsExpensify! Thanks for the update @lakchote! Just want to clarify -- are you going to work on this one yourself, or should we pull in the SWM engineers per the Slack discussion? |
It will be worked on by @hungvu193 |
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Merged into the Xero feature branch |
Deployed to staging yesterday. |
Assigning @mananjadhav as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes. |
PR is still on staging. |
Looks like the PR deployed to prod last week, will manually update the title/labels for the 7-day hold. |
Payment Summary
BugZero Checklist (@stephanieelliott)
|
I had to manually create a job on Upwork for this |
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~017aaac0f9f763d071 |
... ah, we'll handle the payment for this centrally with the guys working on the feature. We can close this out as the regression period is over! |
Ah cool! Ok Upwork job canceled. |
You need to build the page following the steps outlined here.
This will be worked on by SWM engineers, see Slack discussion here.
Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.
The text was updated successfully, but these errors were encountered: