[SIDEPANE] [Due for payment 2025-03-17] [Due for payment 2025-03-13] Build "Stage 1) Build a placeholder help pane, tested via NVP" of "Add live-navigating help side pane" #471592

[mallenexpensify]

Note: This is for @blazejkustra.

The design doc for Add live-navigating help side pane is still going through detailed review. However, I'd like to get a head start on proving out the basics of the technology. There is already a WIP PR here: #56490 Can you please:

1. Implement everything up to Stage 1, then stop
2. Submit this PR for merging

Thanks!

cc @quinthar

Issue Owner

Current Issue Owner: @mallenexpensify

[mallenexpensify]

@blazejkustra can you please comment so I can assign to you? Thx

[blazejkustra]

🚀

[blazejkustra]

Update: I started cleaning the PR that I prepared during SF onshore. I'll provide more details tomorrow on where we stand 🚢

[quinthar]

Great, thanks!!

[blazejkustra]

Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow!

Screen.Recording.2025-02-20.at.19.08.29.mov

[quinthar]

Fantastic! How long before we have a PR that can be merged?

…

On Thu, Feb 20, 2025, 10:13 AM Błażej Kustra ***@***.***> wrote: Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow! https://github.com/user-attachments/assets/39d9804a-2b64-4153-a347-222fe544d986 — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUQT23ZGUTYWBHXNBNT2QYLONAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGMYDCMRWGA> . You are receiving this because you were assigned.Message ID: ***@***.***> [image: blazejkustra]*blazejkustra* left a comment (Expensify/App#56988) <#56988 (comment)> Sorry for not updating earlier. Yesterday, I was busy with other tasks and reviews. Today I got back to work and had major problems with styling due to recent navigation refactor, basically a lot has changed under the hood… The good news is we now have a working side pane with clearer and more structured code. Now that I have a good base I should have more updates tomorrow! https://github.com/user-attachments/assets/39d9804a-2b64-4153-a347-222fe544d986 — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUQT23ZGUTYWBHXNBNT2QYLONAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGMYDCMRWGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[blazejkustra]

Fantastic! How long before we have a PR that can be merged?

To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday.

Is somebody working on the backend part already?

1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp
We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value.

[quinthar]

Hm, good question -- don't block on that. For now we can just test by setting it locally; your PR can be merged either way, right?

…

On Fri, Feb 21, 2025 at 11:52 AM Błażej Kustra ***@***.***> wrote: Fantastic! How long before we have a PR that can be merged? To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday. Is somebody working on the backend part already? 1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value. — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUVHRI4CPDFV7DSKYI32Q57XRAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGQYTQMZSGY> . You are receiving this because you were assigned.Message ID: ***@***.***> [image: blazejkustra]*blazejkustra* left a comment (Expensify/App#56988) <#56988 (comment)> Fantastic! How long before we have a PR that can be merged? To be honest, I thought it would be ready by now, but I keep running into rough edges. Realistically speaking PR should be ready early next week, perhaps Tuesday/Wednesday. Is somebody working on the backend part already? 1.1) Return the nameValuePair.expensify_sidePane in Open/ReconnectApp We return the current value (if any) in OpenApp and ReconnectApp, so the client knows the current state of this value. — Reply to this email directly, view it on GitHub <#56988 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUVHRI4CPDFV7DSKYI32Q57XRAVCNFSM6AAAAABXKPKFOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGQYTQMZSGY> . You are receiving this because you were assigned.Message ID: ***@***.***>

[blazejkustra]

For now we can just test by setting it locally; your PR can be merged either way, right?

That's correct 👍

[blazejkustra]

Update: Today I was working on entering animation for the modal, also created getHelpContent and hooked everything up. PR should be ready to review tomorrow!

update.mov

[blazejkustra]

Update: I’ve just opened the PR for the initial review!

The positioning of the side pane when the RHP is displayed simultaneously is a bit tricky, and there may be some edge cases to consider. @dubielzyk-expensify, please trigger an ad hoc build and let me know what specific areas I should focus on.

Keep in mind that this is Stage 1, so there’s no content yet, and the styling could be refined in future PRs.

[brunovjk]

@quinthar @mallenexpensify Can I have access to the design doc to review the PR? Thanks.

[dubielzyk-expensify]

Awesome start. Added some comments with the other designers in that PR 👍 Lovely progress

[mallenexpensify]

Added you @brunovjk , with comment access, dive in! https://docs.google.com/document/d/1prFcvgUlEGRuL3zE-JH-lhv_BWX2lL2YNw61w4YVnyY/edit?usp=sharing

[quinthar]

Looks like this is nearly done! https://expensify.slack.com/archives/C07NZ8B1VTQ/p1741050408133159?thread_ts=1739423034.121089&cid=C07NZ8B1VTQ

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[brunovjk]

I just reviewed the PR @francoisl, can you take a look please? Also, if possible, assign me here. Thanks.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Initial implementation of the Side Pane #56490
• [CP Staging] Fix: Scroll Issue on Reports Page, side pane appearing after language change #57831

If no regressions arise, payment will be issued on 2025-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @brunovjk requires payment (Needs manual offer from BZ)

[quinthar]

Bumped to push for shipping what we've got, as nobody can see it except explicit testers.

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Scroll Issue on Reports Page, side pane appearing after language change #57831
• [CP Staging] [NoQA] Fix Help Button appearing in production #58110

If no regressions arise, payment will be issued on 2025-03-17. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

@brunovjk @mallenexpensify @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]