Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help panel - Share code appears zoomed in briefly when opening share RHP with help panel #57815

Open
2 of 8 tasks
mitarachim opened this issue Mar 5, 2025 · 12 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Run Onyx.set('nvp_sidePaneExpanded', {}) in console.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Overview.
  3. Click help icon.
  4. Click Share.

Expected Result:

Share code will not appear zoomed in when opening share RHP with help panel.

Actual Result:

Share code appears zoomed in briefly when opening share RHP with help panel.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761418_1741143728924.20250305_105936.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 5, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@francoisl francoisl added Internal Requires API changes or must be handled by Expensify staff Daily KSv2 and removed DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Mar 5, 2025
@francoisl
Copy link
Contributor

Not a blocker, this is part of the new help panel, which is still in development and can only be enabled via a JS snippet.

@twisterdotcom
Copy link
Contributor

Okay... shall we close, or will you self assign or should I find volunteers in #engineering?

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, this regression comes from my #56490 so I'd like to work on it 👀

@QichenZhu
Copy link
Contributor

Hi @twisterdotcom, can I be assigned here since I'm the reviewer of the PR?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 7, 2025
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Mar 7, 2025
@QichenZhu
Copy link
Contributor

Update: Stage 2 of Side Pane project is now on staging.

Should we ask QA to retest?

For me this is still reproducible in Safari and very rarely in Chrome, but it could just be me since my CPU load is high.

Screen.Recording.2025-03-11.at.11.15.55.mov

@techievivek
Copy link
Contributor

Going to ask the QA team for a re-test here.

@techievivek
Copy link
Contributor

@mitarachim
Copy link
Author

Hello @techievivek , issue not reproducible in build v9.1.11-4

20250312_144009.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants