Bank account - Almost done screen shown briefly when coming from choose an account page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.56-0
Reproducible in staging?: Y
**Reproducible in production?:**Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+1985@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #49536

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace and enable expensify card
3. Go to Expensify Card and click on issue card
4. Add a bank account via plaid
5. On choose account page choose saving and click next but watch closely before the next page appears

Expected Result:

Almost done screen does not get shown in between "Choose an account" page and "Personal Info" page

Actual Result:

Almost done screen get shown briefly in between "Choose an account" page and "Personal Info" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6651175_1730383754347.bandicam_2024-10-31_17-04-09-731.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852305752972180049
• Upwork Job ID: 1852305752972180049
• Last Price Increase: 2024-11-01
• Automatic offers:
• DylanDylann | Contributor | 104984187

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[grgia]

Demoted. Reached out to @koko57 in the slack thread

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021852305752972180049

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[D-01576]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Almost done screen shown briefly when coming from choose an account page

What is the root cause of that problem?

ConfirmationStep component inadvertently includes the "Almost done" screen in its path before reaching the intended "Personal Info" page.

What changes do you think we should make in order to solve the problem?

To resolve this, modify the navigation path within the ConfirmationStep component to skip the "Almost done" screen and navigate directly to the "Personal Info" page.

In the ConfirmationStep component, change (line 52):

    useEffect(() => {
        if (!isSuccessful) {
            return;
        }
        Navigation.navigate(backTo ?? ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policyID ?? '-1'));
        Card.clearIssueNewCardFlow();
    }, [backTo, policyID, isSuccessful]);

to :

Navigation.navigate(ROUTES.WORKSPACE_PERSONAL_INFO.getRoute(policyID ?? '-1'));

What alternative solutions did you explore? (Optional)

[koko57]

@grgia I can work on this one 🙂

[koko57]

I will be working on this issue and the one that has the same root cause #50422, but first I need to finish some Workspace Feed issues

[koko57]

I'm finishing my Workspace Feed tasks - I will focus on this issue from Monday.

[mountiny]

@grgia if you want, happy to take over, I have worked with @koko57 on these flows for last couple of weeks. but do not want to force-takeover 😄 so up to you

[melvin-bot]

@eVoloshchak, @koko57, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[grgia]

all yours @mountiny (now you owe me one fun issue in the future)

[koko57]

Mostly finished WFeed issues, now I'm able to fully focus on this one.

[mountiny]

Thanks both

[koko57]

@mountiny today I will help with the new Workspace Feed bugs, they are higher priority? Maybe we can move this one to weekly?

[mountiny]

sounds good

[DylanDylann]

Note for the PR phase, we need to recheck these issues again:

• [$250] VBA - Continue modal is not shown after several attempts #50422
• [$250] Bank Account - User goes to 'Connect manually' flow after 'Start Over' offline #51479

[koko57]

Working on it.

[DylanDylann]

@eVoloshchak Could I take over this issue? Because this is a deploy blocker from the previous issue that I worked with @koko57 and I also have more context on these related issues

cc @mountiny

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[koko57]

Still working on it. I've already removed some unnecessary code, for now it looks fine, looking for some edge cases.

[koko57]

EDIT: I need to rethink my solution. This component has too much complexity, I will try to simplify it a bit but I can't go with the solution I thought of first

[DylanDylann]

Feel free to post a proposal first, then we can discuss it thoroughly together

[koko57]

I tested some other ideas, I really wanted to simplify this logic, but TBH it's really hard.
I tried to reproduce the issue once again on staging but I cannot get the exact behavior consistently.

Untitled.mov

So in my opinion, it doesn't make sense to burn more time on this - but let's retest it first. The only issue I've found - is that when we have the supported currency for the nonUSDBankAccountStep for the workflows we display the non-USD flow and for the Expensify Card we get the modal to change the currency - is it expected?

cc @mountiny

[mountiny]

is that when we have the supported currency for the nonUSDBankAccountStep for the workflows we display the non-USD flow and for the Expensify Card we get the modal to change the currency - is it expected?

For Expensify Card, you need to have USD settlement bank account so I think yes

[izarutskaya]

Issue not reproducible anymore

bandicam.2024-11-29.14-43-01-498.mp4

[mountiny]

Thanks! Lets close then and hopefully we dont have to handle this one again