[$250] VBA - Continue modal is not shown after several attempts

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.46-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49687

Action Performed:

Precondition: user has several workspaces, e.g. A, B, C

1. Go to workspace A > More features > enable Expensify Cards
2. Go to Expensify Cards tab > issue new card
3. Start add VBA flow
4. Close VBA flow RHN on Personal info step
5. Go to workspace B > More features > enable Expensify Cards
6. Go to Expensify Cards tab (ws B) > issue new card
7. Repeat step 2-6 several times

Expected Result:

On step 5, starting page of VBA with setup types displayed
On step 6, Continue page with options 'Continue' and 'Start over' displayed

Actual Result:

On step 5, starting page of VBA with setup types displayed
On step 6, after several attempts, user is navigated to Personal info step he left on step 4

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6628321_1728391481784.vba_fail.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843708220772796908
• Upwork Job ID: 1843708220772796908
• Last Price Increase: 2024-10-08
• Automatic offers:
• DylanDylann | Contributor | 104330185

Issue Owner

Current Issue Owner: @koko57

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcochavezf]

Seems this issue stems from this PR. Given that PR fixed a crash and this workflow is not common, I wouldn't consider it a deploy blocker, but it would still require a fix cc @koko57 @mountiny @grgia @DylanDylann Feel free to take it over since you have more context than I do :)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843708220772796908

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@koko57 @DylanDylann can you please have a look? thanks!

[koko57]

@mountiny ok I will look into this today, you can assign me 🙂

[koko57]

I haven't much time to look into this one yet, I'll try to check it today but even so I probably won't be able to fix it till EOD.
I'm ooo next Mon and Tue I will come back to it on Wednesday.

Probably there is some problem with setting state, maybe also a problem with updating the data in Onyx. While working on the original issue (with the crash) I was wondering if we should change this continue modal and the start page (with manual/plaid connection choice and the image) into a separate step - we need to display one of them always anyway.
This means a bit more work, but maybe it will be more stable than the current solution.

[mountiny]

Thanks for the insights, this is a niche bug so we can take time to get back to this

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix some bugs on Bank account Flow #51315

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

@koko57 @DylanDylann sounds good to me, thanks!

[koko57]

@mountiny maybe when the payment is done here we can close this one and I will work on the refactor in this issue: #51799

[mountiny]

@koko57 Sorry, maybe I m not understanding. I think we need a new PR, the original was reverted so there is no payment here

[DylanDylann]

If we handle this issue in #51799, please make sure test this bug again in the PR phase and now we can close this one

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @adelekennedy you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[mountiny]

I believe no payments here as the PR was reverted, still discussing if we going to handle the fix here or elsewhere

[DylanDylann]

@mountiny I believe that we need to reopen this issue because #51799 is closed without PR

[DylanDylann]

cc @koko57

[mountiny]

@kavimuru can your team please retest this issue?

[adelekennedy]

Bump on the retest!

[mountiny]

Asked here

[izarutskaya]

It works as expected. Check please videos

Screen.Recording.2024-12-12.at.11.26.30.AM.mp4

Screen.Recording.2024-12-12.At.4.52.23.Pm.mp4