[$250] Bank account - Different error message for incorrect validation amounts

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #45732

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows
3. Click Connect bank account
4. Click Connect manually
5. Proceed to "Validate your bank account" step
6. Enter incorrect amount for each transaction value
7. Click Validate

Expected Result:

The error message will be "The validation amounts you entered are incorrect. Please double-check your bank statement and try again

Actual Result:

The error message is "The validate code you entered is incorrect, please try again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0f2937fb2d6512f
• Upwork Job ID: 1820565013326918810
• Last Price Increase: 2024-08-05

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Different error message for incorrect validation amounts

What is the root cause of that problem?

The root cause is that the response from WRITE_COMMANDS.VALIDATE_BANK_ACCOUNT_WITH_TRANSACTIONS is not 'bankAccount.error.validationAmounts' and merges a different response error message but this.

"The validate code you entered is incorrect, please try again"

However, on the front end, we use 'bankAccount.error.validationAmounts' when handling the BankAccountValidationForm error.

App/src/pages/ReimbursementAccount/ConnectBankAccount/components/BankAccountValidationForm.tsx

Line 94 in e36fcce

BankAccounts.validateBankAccount(bankAccountID, validateCode, policyID);

App/src/libs/actions/BankAccounts.ts

Lines 332 to 338 in b0ca6ad

	failureData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.REIMBURSEMENT_ACCOUNT,
	value: {
	isLoading: false,
	errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('bankAccount.error.validationAmounts'),

What changes do you think we should make in order to solve the problem?

We should bring the backend validation of the input amounts to the front end to allow the front end to validate the amount of input before sending it to the backend.

If this is possible, it would be reasonable especially offline.

What alternative solutions did you explore? (Optional)

From the backend, we stop sending back the secondary error message when the amount is invalid and depends on the error message used in the front end.

App/src/libs/actions/BankAccounts.ts

Line 338 in b0ca6ad

errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('bankAccount.error.validationAmounts'),

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0f2937fb2d6512f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@Tony-MK Thanks for your proposal! Just to clarify, are you saying that the BE is returning the incorrect error The validate code you entered is incorrect, please try again?

[Tony-MK]

@jjcoffee, Yeah, the backend is returning a different error message.

[jjcoffee]

Sounds like a BE fix is required here then @johncschuster 🙏

[melvin-bot]

@johncschuster @jjcoffee this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[rlinoz]

This is deployed, we can close it.