Skip to content

Commit b0ca6ad

Browse files
authored
Merge pull request #46550 from ikevin127/fix/proposal-police-notifications
[NoQA] FIX / ProposalPolice™ GH Actions Workflow - Graceful Fail (Solves Notifications on Fail Issue)
2 parents e36fcce + 2abbb6f commit b0ca6ad

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/actions/javascript/proposalPoliceComment/index.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -18061,7 +18061,9 @@ async function run() {
1806118061
}
1806218062
run().catch((error) => {
1806318063
console.error(error);
18064-
process.exit(1);
18064+
// Zero status ensures that the action is marked as successful regardless the outcome
18065+
// which means that no failure notification is sent to issue's subscribers
18066+
process.exit(0);
1806518067
});
1806618068

1806718069

.github/actions/javascript/proposalPoliceComment/proposalPoliceComment.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -103,5 +103,7 @@ async function run() {
103103

104104
run().catch((error) => {
105105
console.error(error);
106-
process.exit(1);
106+
// Zero status ensures that the action is marked as successful regardless the outcome
107+
// which means that no failure notification is sent to issue's subscribers
108+
process.exit(0);
107109
});

0 commit comments

Comments
 (0)