[HOLD] [$250] Remove New Workspace option from Global Create

[JmillsExpensify]

As part of our ideal nav release, we have made it super easy to create a workspace, which was not previously the case. This includes an empty state to create a workspace when you tap the "wrench" in the bottom nav, as well as one click access to any workspaces you've previously created.

As a result, the New Workspace option is no longer needed. Let's remove it from Global Create.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f04217489c09c36e
• Upwork Job ID: 1755604175468281856
• Last Price Increase: 2024-02-08
• Automatic offers:
• situchan | Reviewer | 0
• esh-g | Contributor | 0

[melvin-bot]

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f04217489c09c36e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove New Workspace option from Global Create

What is the root cause of that problem?

Request feature

What changes do you think we should make in order to solve the problem?

Remove the New Worksapce option from
Remove from here

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 193 to 204 in f697c89

	...(!props.isLoading && !Policy.hasActiveFreePolicy(props.allPolicies)
	? [
	{
	displayInDefaultIconColor: true,
	contentFit: 'contain',
	icon: Expensicons.NewWorkspace,
	iconWidth: 46,
	iconHeight: 40,
	text: translate('workspace.new.newWorkspace'),
	description: translate('workspace.new.getTheExpensifyCardAndMore'),
	onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
	},

What alternative solutions did you explore? (Optional)

N/A

[esh-g]

Proposal

Please re-state the problem we are trying to solve

Remove New Workspace option from Global Create

What is the root cause of the problem?

N/A

What changes should be made to fix this?

We should remove the menu item here:

...(!props.isLoading && !Policy.hasActiveFreePolicy(props.allPolicies)
  ? [
        {
            displayInDefaultIconColor: true,
            contentFit: 'contain',
            icon: Expensicons.NewWorkspace,
            iconWidth: 46,
            iconHeight: 40,
            text: translate('workspace.new.newWorkspace'),
            description: translate('workspace.new.getTheExpensifyCardAndMore'),
            onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
        },
    ]
  : []),

in FloatingActionButtonAndPopover

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove New Workspace option from Global Create

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

To fix this issue we can delete this element from FloatingActionButtonAndPopover

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 209 to 220 in cbc4f1e

	...(!props.isLoading && !Policy.hasActiveFreePolicy(props.allPolicies)
	? [
	{
	displayInDefaultIconColor: true,
	contentFit: 'contain',
	icon: Expensicons.NewWorkspace,
	iconWidth: 46,
	iconHeight: 40,
	text: translate('workspace.new.newWorkspace'),
	description: translate('workspace.new.getTheExpensifyCardAndMore'),
	onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
	},

Plus we need delete getTheExpensifyCardAndMore translate and Expensicons.NewWorkspace icon
Since this is the only place where we use these elements

Also I think about hasActiveFreePolicy
There are only 2 places where we use it
1st place here
And the second one is in deleteWorkspace
So we can move logic hasActiveFreePolicy inside deleteWorkspace to make the code cleaner

What alternative solutions did you explore? (Optional)

NA

[esh-g]

Note

The first comment from @GandalfGwaihir was just 'dibs' and proposal was edited in later.

[situchan]

@esh-g was the first to provide complete proposal.
Code cleanup can be done in PR phase.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allgandalf]

Hey @situchan , @esh-g too edited her proposal later on with complete proposal first she had only solution part:)

[ZhenjaHorbach]

Actually I agree
I understand that this is a question of speed
But there isn’t even a full-fledged proposal with a link here

[situchan]

As this is new feature, this doesn't require specific root cause. They linked the correct code where to implement.
@ZhenjaHorbach I think you already got benefit from other issue today. So let's end up unrelated discussion here.

[esh-g]

As to address those concerns:

• The first comment did indeed have a solution that could be understood rather than 'dibs'
• It is allowed to edit proposals and if we compare the last edit time, my solution was still earlier

I hope this clarifies my position, thanks for your understanding

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

Decreasing the rewards due to relative simplicity of this job.

[trjExpensify]

Are we still doing this?

[trjExpensify]

I've put it in Polish for the time being.

[JmillsExpensify]

I'm not sure if we will, though I think it makes sense to keep open for a little bit longer. Polish sounds right to me.

[trjExpensify]

Cool, sounds good!

[situchan]

Ideal Nav v2 was deployed to production. Is this still on hold?

[JmillsExpensify]

Yes, it is.

[JmillsExpensify]

Still on hold

[JmillsExpensify]

Still on hold

[JmillsExpensify]

Still on hold pending onboarding improvements.

[JmillsExpensify]

With no immediate plans to do this, I'm going to go ahead and close this issue. Additionally, since proposals were made and reviewed, I am willing to compensate the following:

• Contributor: @esh-g $125
• Contributor+: @situchan $125

[JmillsExpensify]

Contributor paid out and C+ offer sent. Going to close this issue, but please comment here when you've accepted the offer and I'll issue payment.

[situchan]

@JmillsExpensify accepted offer. Thanks

[JmillsExpensify]

C+ paid out, so we're all good here!