Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Workspace button shows on Global create when Collect workspaces exist #38749

Closed
Gonals opened this issue Mar 21, 2024 · 5 comments
Closed

New Workspace button shows on Global create when Collect workspaces exist #38749

Gonals opened this issue Mar 21, 2024 · 5 comments
Assignees
@twisterdotcom @Gonals @mollfpr
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@Gonals
Copy link
Contributor

Gonals commented Mar 21, 2024 •
edited by melvin-bot bot
Loading

Problem

New Workspace button shows on Global create when Collect workspaces exist, but it should only show when there are no available workspaces

Why is this important?

It is inconsistent behavior

Solution

Hide it when we have Newdot-enabled Collect workspaces

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe6975faa279e152
  • Upwork Job ID: 1770831183603826688
  • Last Price Increase: 2024-03-21
@Gonals Gonals added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Mar 21, 2024
@Gonals Gonals self-assigned this Mar 21, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01fe6975faa279e152

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 21, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 21, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Gonals Gonals mentioned this issue Mar 21, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 21, 2024
@situchan
Copy link
Contributor

We're removing this in #36153

@twisterdotcom
Copy link
Contributor

@situchan we can close this as a dupe then right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twisterdotcom twisterdotcom

@Gonals Gonals

@mollfpr mollfpr

Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@twisterdotcom @Gonals @mollfpr @situchan