[$1000] can’t check off a task when it is “done”

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Assign a task to user A
2. Log in as user B and "Mark as done" for the assigned task
3. Login as user A and check off the task

Expected Result:

Able to check off

Actual Result:

Not able to check off

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.657.mp4

Expensify/Expensify Issue URL:
Issue reported by: @joaniew
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684311858049629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b784d341e4d6cdf
• Upwork Job ID: 1660594272412274688
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bfitzexpensify]

Reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b784d341e4d6cdf

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @robertjchen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

can’t check off a task when it is “done”

What is the root cause of that problem?

I think there is a redundant check whether task is completed or not in report actions view:

App/src/components/ReportActionItem/TaskPreview.js

Lines 56 to 58 in c917c44

	const isTaskCompleted =
	(props.taskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.taskReport.statusNum === CONST.REPORT.STATUS.APPROVED) ||
	(props.action.childStateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.action.childStatusNum === CONST.REPORT.STATUS.APPROVED);

In TaskHeader of taskReport, we only check status of report itself

App/src/components/TaskHeader.js

Line 39 in c917c44

const isCompleted = props.report.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.report.statusNum === CONST.REPORT.STATUS.APPROVED;

=> It leads to show incorrect status of a task in reportActionsView

What changes do you think we should make in order to solve the problem?

We need to remove redundant check on props.action to keep it consistency with TaskHeader of taskReport.

So the correct condition here should be:

const isTaskCompleted =
        (props.taskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.taskReport.statusNum === CONST.REPORT.STATUS.APPROVED);

There are some valid reasons to do it:

• When we build optimistic data for ReopenTask/CompleteTask, we only update status of taskReport
• The success API also only return the status of taskReport
  

So the status of taskReportAction is outdated.

[kushu7]

Its a BE issue. when we reopen task
action ${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID} throwing error. thats why action is not getting updated.

[jjcoffee]

This is a BE issue as there is no pusher event to update the task for user A's chat so it's not synchronised with the task's real state (that's why the checkbox doesn't get checked on user A's side even though the task was marked as complete by user B). You'll only get the updated task status if you open the task report.

[Santhosh-Sellavel]

I'm unassigning due to limited availability. Can you a assign new C+ here by re-applying the external label here, thanks!

Also @robertjchen Not sure but seems like a backend issue from a couple of comments above. Please check that before moving forward

cc: @bfitzexpensify

[bfitzexpensify]

@robertjchen before I assign a new C+, do you want to take a look at #19298 (comment) and confirm if this is a back-end or front-end issue?

[Santhosh-Sellavel]

@bfitzexpensify I'm happy take this back if C+ Needed. I'm available now.

[robertjchen]

Yes, it looks like it's on the backend- taking this internal to work on further 🤔

[bfitzexpensify]

@aimane-chnaif @robertjchen thoughts on @hoangzinh's comment?

[bfitzexpensify]

bump @aimane-chnaif @robertjchen

[robertjchen]

I think the core issue around inconsistent state should be resolved rather than the FE workaround. The backend should do as described here #19298 (comment) 🤔

[bfitzexpensify]

Cool, I agree with the general idea of solving the core issue rather than using a workaround. Let's keep this internal

[melvin-bot]

@robertjchen @bfitzexpensify @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

This one's internal, Melv

[robertjchen]

I think I found the source of the issue on the backend. Draft PR linked and testing out the fix 👍

[robertjchen]

Ran into some problems testing locally, going to revisit tomorrow to see if I can get it to work, hopefully will have the PR ready by EOW.

[robertjchen]

Still testing things out locally

[melvin-bot]

@robertjchen @bfitzexpensify @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@robertjchen, @bfitzexpensify, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[robertjchen]

Top priority today 👀

[robertjchen]

Fix confirmed, working on finalizing the PR/screenshots, etc. 👍

[robertjchen]

The fix is currently on staging

[melvin-bot]

@robertjchen, @bfitzexpensify, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

@robertjchen looks like this is on prod now (https://github.com/Expensify/Web-Expensify/pull/37714#issuecomment-1601887889) - we good to close this out?

[robertjchen]

Yep, we're all set here!