[$1000] Task checkbox not updating when task is marked as incomplete

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. Create a task
2. Go back to the parent chat where the task was created
3. Click on the checkbox to mark the task as complete
4. Click on the checkbox to mark the task as incomplete

Expected Result:

Describe what you think should've happened
The checkbox should become unchecked

Actual Result:

Describe what actually happened
Notice that the checkbox still remains checked

Workaround:

Clicking into the task will show the current state of the task

Platforms:

Which of our officially supported platforms is this issue occurring on? All

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @thienlnam
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128be1224a5f0cdd5
• Upwork Job ID: 1658941268622680064
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[adelekennedy]

just happened to me today - real bug, able to reproduce and couldn't find a duplicate

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128be1224a5f0cdd5

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

I think this issue should be internal. When I mark/unmark several time, the API with command ReopenTask got error

[puneetlath]

Seems your right! Thanks @hoangzinh. Marking Internal.

[melvin-bot]

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

[thienlnam]

The API command failing makes sense, but we should also add some feedback on the user end so they know that the command failed, and then disable the button until they address the error. I imagine this would look like the RBR error we se when we fail to add a comment

[melvin-bot]

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

[jjcoffee]

Just a heads up, this is not only a BE issue as far as I can tell. To summarise my proposal on a related task, there is an issue that's fully FE where the reportAction (linked to TaskPreview) will never update it's task completion state (specifically childStateNum or childStatusNum) since we don't provide any optimisticData or successData to update the reportAction (and/or data in the API response).

So when you initially complete the task, it's only the taskReport that updated to completed, the reportAction stays open. If you switch reports or do something that triggers openReport, this seems to successfully update the reportAction. But now if you try and reopen the task, taskReport gets successfully reopened, but since the task status in reportAction is not updated the taskPreview will display as if it's still completed, i.e. the checkmark stays (even though the API request succeeds, so the task is actually now open).

If you then try and click the checkbox again, this will call ReopenTask, even though the task is already open (just not displaying as such). This of course then returns the BE error noted here - "Incorrect report state" - which is to indicate something is out of sync (which is the FE's fault!).

I can repost my proposal here if this gets marked External again, but it's the same fix so I just thought I'd flag mainly to save someone debug time!

[hoangzinh]

Oh it seems we have duplicated issue here #19298. And I have my proposal there too #19298

[jjcoffee]

@hoangzinh That's a bit of a different issue as it deals with synchronising the task across two different users.

[melvin-bot]

@puneetlath, @eVoloshchak, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@thienlnam re-assigning over to you as discussed here. Thanks!

[melvin-bot]

@eVoloshchak, @thienlnam, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

@thienlnam I saw you thumbs up the comment above - should we throw the external label on here for some contributor help?

[melvin-bot]

@eVoloshchak @thienlnam @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[thienlnam]

Yeah, let me update the title - we basically need better handling for when the task cannot be marked as incomplete due to the state of the task.

Though actually this may actually also be solved in #19157 so we can focus over there